Libreoffice support #938
Open
Libreoffice support #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not transfered correctly.
functionality listed at: https://github.com/jonnieey/Sc-im-Tutorial/blob/master/Lesson11_Numeric_Functions.sc due to being the only location where all the functionality was listed in a centralized manner.
|
Hello. Please share the file you had problems with. Thank you! |
|
Absolutely, it is already in "tests/formats/TestScIm.ods" in the branch. |
part of the conversion issues
they are compressed by the ods format. Added a new ods file to test for the correct behaviour
|
If you want to add testing for these changes, what I think it can be very simple and reliable is to have a command line option to import a "ods" file and save it in the "sc-im" format, and with diff or another command check if the exported file is matching the one known to be a good conversion. |
|
Hello @gugolple I am thinking on merging this. How you been using this patch lately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I found the software quite interesting and useful.
For my specific use-case I was starting from an libreoffice sheet and I wanted to import it into your system. When doing that I noticed that some basic math functionality was missing. The best reference I found for the functionality available was at: jonnieey/Sc-im-Tutorial where it more or less listed quite a few available functionality.
This commit is mostly regarding the correct import and mapping of the aforementioned functionality. I have also added a very basic a simple spreadsheet to test the functionality against.
In that regard, I have noticed that there are some issues at the import stage, where not all cells are recognized properly. But I did not want to push forward with more changes before having a formal communication with you, the author.
I am more than happy to discuss and change my approach if you find any of the changes done unnecesary.
Thank you and kind regards,
Gugolple.