refactor: modernize array and string last element access using .at(-1)

alan-agius4 · alan-agius4 · commit 2d5270abb9d3 · 2025-11-20T14:06:14.000Z
Replace usages of old patterns.
diff --git a/packages/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts b/packages/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts
@@ -105,8 +105,7 @@ DDIy4xXPW1STWfsmSYJfYW3wa0wk+pJQ3j2cTzkPQQ8gwpvM3U9DJl43uwb37v6I
 
 async function goToPageAndWaitForWS(page: Page, url: string): Promise<void> {
   const baseUrl = url.replace(/^http/, 'ws');
-  const socksRequest =
-    baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
+  const socksRequest = baseUrl.at(-1) === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
   // Create a Chrome dev tools session so that we can capturing websocket request.
   // https://github.com/puppeteer/puppeteer/issues/2974
 
diff --git a/packages/angular/build/src/builders/dev-server/tests/execute-fetch.ts b/packages/angular/build/src/builders/dev-server/tests/execute-fetch.ts
@@ -28,7 +28,7 @@ export async function executeOnceAndFetch<T>(
         let content = undefined;
         if (executionResult.result?.success) {
           let baseUrl = `${executionResult.result.baseUrl}`;
-          baseUrl = baseUrl[baseUrl.length - 1] === '/' ? baseUrl : `${baseUrl}/`;
+          baseUrl = baseUrl.at(-1) === '/' ? baseUrl : `${baseUrl}/`;
           const resolvedUrl = new URL(url, baseUrl);
           const originalResponse = await fetch(resolvedUrl, options?.request);
           response = originalResponse.clone();
@@ -68,7 +68,7 @@ export async function executeOnceAndGet<T>(
         let content = undefined;
         if (executionResult.result?.success) {
           let baseUrl = `${executionResult.result.baseUrl}`;
-          baseUrl = baseUrl[baseUrl.length - 1] === '/' ? baseUrl : `${baseUrl}/`;
+          baseUrl = baseUrl.at(-1) === '/' ? baseUrl : `${baseUrl}/`;
           const resolvedUrl = new URL(url, baseUrl);
 
           response = await new Promise<IncomingMessage>((resolve) =>
diff --git a/packages/angular/build/src/builders/dev-server/vite/index.ts b/packages/angular/build/src/builders/dev-server/vite/index.ts
@@ -243,9 +243,7 @@ export async function* serveWithVite(
           const baseHref = result.detail['htmlBaseHref'] as string;
           // Remove trailing slash
           serverOptions.servePath =
-            baseHref !== './' && baseHref[baseHref.length - 1] === '/'
-              ? baseHref.slice(0, -1)
-              : baseHref;
+            baseHref !== './' && baseHref.at(-1) === '/' ? baseHref.slice(0, -1) : baseHref;
         }
 
         assetFiles.clear();
diff --git a/packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts b/packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts
@@ -40,7 +40,7 @@ export function createAngularAssetsMiddleware(
     // The base of the URL is unused but required to parse the URL.
     const pathname = pathnameWithoutBasePath(req.url, server.config.base);
     const extension = extname(pathname);
-    const pathnameHasTrailingSlash = pathname[pathname.length - 1] === '/';
+    const pathnameHasTrailingSlash = pathname.at(-1) === '/';
 
     // Rewrite all build assets to a vite raw fs URL
     const asset = assets.get(pathname);
diff --git a/packages/angular/build/src/utils/project-metadata.ts b/packages/angular/build/src/utils/project-metadata.ts
@@ -15,7 +15,7 @@ import { join } from 'node:path';
  * @returns A normalized path string.
  */
 export function normalizeDirectoryPath(path: string): string {
-  const last = path[path.length - 1];
+  const last = path.at(-1);
   if (last === '/' || last === '\\') {
     return path.slice(0, -1);
   }
diff --git a/packages/angular/build/src/utils/server-rendering/manifest.ts b/packages/angular/build/src/utils/server-rendering/manifest.ts
@@ -77,7 +77,7 @@ export function generateAngularServerAppEngineManifest(
 
   // Remove trailing slash but retain leading slash.
   let basePath = baseHref || '/';
-  if (basePath.length > 1 && basePath[basePath.length - 1] === '/') {
+  if (basePath.length > 1 && basePath.at(-1) === '/') {
     basePath = basePath.slice(0, -1);
   }
 
diff --git a/packages/angular/build/src/utils/url.ts b/packages/angular/build/src/utils/url.ts
@@ -22,7 +22,7 @@
  */
 export function stripTrailingSlash(url: string): string {
   // Check if the last character of the URL is a slash
-  return url.length > 1 && url[url.length - 1] === '/' ? url.slice(0, -1) : url;
+  return url.length > 1 && url.at(-1) === '/' ? url.slice(0, -1) : url;
 }
 
 /**
@@ -75,7 +75,7 @@ export function addLeadingSlash(url: string): string {
  */
 export function addTrailingSlash(url: string): string {
   // Check if the URL already end with a slash
-  return url[url.length - 1] === '/' ? url : `${url}/`;
+  return url.at(-1) === '/' ? url : `${url}/`;
 }
 
 /**
@@ -107,7 +107,7 @@ export function joinUrlParts(...parts: string[]): string {
     if (part[0] === '/') {
       normalizedPart = normalizedPart.slice(1);
     }
-    if (part[part.length - 1] === '/') {
+    if (part.at(-1) === '/') {
       normalizedPart = normalizedPart.slice(0, -1);
     }
     if (normalizedPart !== '') {
diff --git a/packages/angular/cli/src/command-builder/utilities/json-schema.ts b/packages/angular/cli/src/command-builder/utilities/json-schema.ts
@@ -334,7 +334,7 @@ export async function parseJsonSchemaToOptions(
       // Skip any non-property items.
       return;
     }
-    const name = ptr[ptr.length - 1];
+    const name = ptr.at(-1) as string;
 
     const types = getSupportedTypes(current);
 
diff --git a/packages/angular/ssr/src/utils/url.ts b/packages/angular/ssr/src/utils/url.ts
@@ -22,7 +22,7 @@
  */
 export function stripTrailingSlash(url: string): string {
   // Check if the last character of the URL is a slash
-  return url.length > 1 && url[url.length - 1] === '/' ? url.slice(0, -1) : url;
+  return url.length > 1 && url.at(-1) === '/' ? url.slice(0, -1) : url;
 }
 
 /**
@@ -75,7 +75,7 @@ export function addLeadingSlash(url: string): string {
  */
 export function addTrailingSlash(url: string): string {
   // Check if the URL already end with a slash
-  return url[url.length - 1] === '/' ? url : `${url}/`;
+  return url.at(-1) === '/' ? url : `${url}/`;
 }
 
 /**
@@ -106,7 +106,7 @@ export function joinUrlParts(...parts: string[]): string {
     if (part[0] === '/') {
       normalizedPart = normalizedPart.slice(1);
     }
-    if (part[part.length - 1] === '/') {
+    if (part.at(-1) === '/') {
       normalizedPart = normalizedPart.slice(0, -1);
     }
     if (normalizedPart !== '') {
diff --git a/packages/angular_devkit/architect/src/jobs/simple-scheduler_spec.ts b/packages/angular_devkit/architect/src/jobs/simple-scheduler_spec.ts
@@ -168,7 +168,7 @@ describe('SimpleScheduler', () => {
     // Might be out of order.
     expect(done).toEqual(jasmine.arrayContaining([1, 2, 3, 4, 5, 6, 7]));
     // Verify at least partial order.
-    expect(done[done.length - 1]).toBe(7);
+    expect(done.at(-1)).toBe(7);
     expect(done.indexOf(4)).toBeGreaterThan(done.indexOf(1));
     expect(done.indexOf(5)).toBeGreaterThan(done.indexOf(2));
     expect(done.indexOf(6)).toBeGreaterThan(done.indexOf(3));
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts
@@ -108,8 +108,7 @@ async function createProxy(target: string, secure: boolean, ws = true): Promise<
 
 async function goToPageAndWaitForWS(page: Page, url: string): Promise<void> {
   const baseUrl = url.replace(/^http/, 'ws');
-  const socksRequest =
-    baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
+  const socksRequest = baseUrl.at(-1) === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
   // Create a Chrome dev tools session so that we can capturing websocket request.
   // https://github.com/puppeteer/puppeteer/issues/2974
 
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/tests/execute-fetch.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/tests/execute-fetch.ts
@@ -27,7 +27,7 @@ export async function executeOnceAndFetch<T>(
         let content = undefined;
         if (executionResult.result?.success) {
           let baseUrl = `${executionResult.result.baseUrl}`;
-          baseUrl = baseUrl[baseUrl.length - 1] === '/' ? baseUrl : `${baseUrl}/`;
+          baseUrl = baseUrl.at(-1) === '/' ? baseUrl : `${baseUrl}/`;
           const resolvedUrl = new URL(url, baseUrl);
           const originalResponse = await fetch(resolvedUrl, options?.request);
           response = originalResponse.clone();
diff --git a/packages/angular_devkit/core/src/utils/template.ts b/packages/angular_devkit/core/src/utils/template.ts
@@ -253,9 +253,7 @@ function templateWithSourceMap(ast: TemplateAst, options?: TemplateOptions): str
     ]),
   );
 
-  const end = ast.children.length
-    ? ast.children[ast.children.length - 1].end
-    : { line: 0, column: 0 };
+  const end = ast.children.length ? ast.children.at(-1)?.end : { line: 0, column: 0 };
   const nodes = ast.children
     .reduce((chunk, node) => {
       let code: string | SourceNode | (SourceNode | string)[] = '';
diff --git a/packages/angular_devkit/core/src/virtual-fs/path.ts b/packages/angular_devkit/core/src/virtual-fs/path.ts
@@ -57,7 +57,7 @@ export const NormalizedRoot: Path = NormalizedSep;
  */
 export function split(path: Path): PathFragment[] {
   const fragments = path.split(NormalizedSep).map((x) => fragment(x));
-  if (fragments[fragments.length - 1].length === 0) {
+  if (fragments.at(-1)?.length === 0) {
     fragments.pop();
   }
 
diff --git a/packages/angular_devkit/schematics/src/tree/action.ts b/packages/angular_devkit/schematics/src/tree/action.ts
@@ -31,7 +31,7 @@ export class ActionList implements Iterable<Action> {
     this._actions.push({
       ...(action as Action),
       id: _id++,
-      parent: this._actions[this._actions.length - 1]?.id ?? 0,
+      parent: this._actions.at(-1)?.id ?? 0,
     });
   }
 
diff --git a/packages/angular_devkit/schematics/src/workflow/base.ts b/packages/angular_devkit/schematics/src/workflow/base.ts
@@ -91,7 +91,7 @@ export abstract class BaseWorkflow implements Workflow {
   }
 
   get context(): Readonly<WorkflowExecutionContext> {
-    const maybeContext = this._context[this._context.length - 1];
+    const maybeContext = this._context.at(-1);
     if (!maybeContext) {
       throw new Error('Cannot get context when workflow is not executing...');
     }
@@ -146,7 +146,7 @@ export abstract class BaseWorkflow implements Workflow {
   execute(
     options: Partial<WorkflowExecutionContext> & RequiredWorkflowExecutionContext,
   ): Observable<void> {
-    const parentContext = this._context[this._context.length - 1];
+    const parentContext = this._context.at(-1);
 
     if (!parentContext) {
       this._lifeCycle.next({ kind: 'start' });
diff --git a/tests/legacy-cli/e2e_runner.ts b/tests/legacy-cli/e2e_runner.ts
@@ -121,7 +121,7 @@ const logger = createConsoleLogger(argv.verbose, process.stdout, process.stderr,
 
 const logStack = [logger];
 function lastLogger() {
-  return logStack[logStack.length - 1];
+  return logStack.at(-1)!;
 }
 
 // Under bazel the compiled file (.js) and types (.d.ts) are available.

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ import { join } from 'node:path';`
`15`	`15`	`* @returns A normalized path string.`
`16`	`16`	`*/`
`17`	`17`	`export function normalizeDirectoryPath(path: string): string {`
`18`		`- const last = path[path.length - 1];`
	`18`	`+ const last = path.at(-1);`
`19`	`19`	`if (last === '/' \|\| last === '\\') {`
`20`	`20`	`return path.slice(0, -1);`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ export function generateAngularServerAppEngineManifest(`
`77`	`77`
`78`	`78`	`// Remove trailing slash but retain leading slash.`
`79`	`79`	`let basePath = baseHref \|\| '/';`
`80`		`- if (basePath.length > 1 && basePath[basePath.length - 1] === '/') {`
	`80`	`+ if (basePath.length > 1 && basePath.at(-1) === '/') {`
`81`	`81`	`basePath = basePath.slice(0, -1);`
`82`	`82`	`}`
`83`	`83`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`*/`
`23`	`23`	`export function stripTrailingSlash(url: string): string {`
`24`	`24`	`// Check if the last character of the URL is a slash`
`25`		`- return url.length > 1 && url[url.length - 1] === '/' ? url.slice(0, -1) : url;`
	`25`	`+ return url.length > 1 && url.at(-1) === '/' ? url.slice(0, -1) : url;`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`/**`
`@@ -75,7 +75,7 @@ export function addLeadingSlash(url: string): string {`
`75`	`75`	`*/`
`76`	`76`	`export function addTrailingSlash(url: string): string {`
`77`	`77`	`// Check if the URL already end with a slash`
`78`		- return url[url.length - 1] === '/' ? url : `${url}/`;
	`78`	+ return url.at(-1) === '/' ? url : `${url}/`;
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`/**`
`@@ -107,7 +107,7 @@ export function joinUrlParts(...parts: string[]): string {`
`107`	`107`	`if (part[0] === '/') {`
`108`	`108`	`normalizedPart = normalizedPart.slice(1);`
`109`	`109`	`}`
`110`		`- if (part[part.length - 1] === '/') {`
	`110`	`+ if (part.at(-1) === '/') {`
`111`	`111`	`normalizedPart = normalizedPart.slice(0, -1);`
`112`	`112`	`}`
`113`	`113`	`if (normalizedPart !== '') {`
Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ export async function parseJsonSchemaToOptions(`
`334`	`334`	`// Skip any non-property items.`
`335`	`335`	`return;`
`336`	`336`	`}`
`337`		`- const name = ptr[ptr.length - 1];`
	`337`	`+ const name = ptr.at(-1) as string;`
`338`	`338`
`339`	`339`	`const types = getSupportedTypes(current);`
`340`	`340`