ci: Upgrade linter (#808)

Author: sanjushahgupta

.golangci.yml

@@ -13,7 +13,7 @@ linters:
     - revive
     - godot
     - gofumpt
-    - gomnd
+    - mnd
     - gosimple
     - govet
     - ineffassign
@@ -32,7 +32,7 @@ linters-settings:
     rules:
       - name: package-comments
         disabled: true
-  gomnd:
+  mnd:
     ignored-numbers: ['0', '1', '2', '3']
 issues:
   exclude-use-default: false

Makefile

@@ -44,7 +44,7 @@ install:
 lint:
 	@if ! command -v golangci-lint > /dev/null 2>&1; then \
 		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | \
-		sh -s -- -b "$$(go env GOPATH)/bin" v1.57.2 ; \
+		sh -s -- -b "$$(go env GOPATH)/bin" v1.62.2 ; \
 	fi
 	golangci-lint run ./...
 

internal/cmd/root/help.go

@@ -20,12 +20,12 @@ func helpFunc(cmd *cobra.Command, _ []string) {
 	out := cmd.OutOrStdout()
 	for _, e := range entries {
 		if e.Title != "" {
-			fmt.Fprintf(out, "\033[1m%s\033[0m\n", e.Title)
-			fmt.Fprintln(out, text.Indent(strings.Trim(e.Body, "\r\n"), "  "))
+			_, _ = fmt.Fprintf(out, "\033[1m%s\033[0m\n", e.Title)
+			_, _ = fmt.Fprintln(out, text.Indent(strings.Trim(e.Body, "\r\n"), "  "))
 		} else {
-			fmt.Fprintln(out, e.Body)
+			_, _ = fmt.Fprintln(out, e.Body)
 		}
-		fmt.Fprintln(out)
+		_, _ = fmt.Fprintln(out)
 	}
 }
 

internal/cmdutil/datetime.go

@@ -26,7 +26,7 @@ var (
 
 // DateStringToJiraFormatInLocation parses a standard string to jira compatible RFC3339 datetime format.
 //
-//nolint:gomnd
+//nolint:mnd
 func DateStringToJiraFormatInLocation(value string, timezone string) (string, error) {
 	if value == "" || value == "0" || value == "0000-00-00 00:00:00" || value == "0000-00-00" || value == "00:00:00" {
 		return "", nil

internal/cmdutil/utils.go

@@ -71,17 +71,17 @@ func Info(msg string) *spinner.Spinner {
 
 // Success prints success message in stdout.
 func Success(msg string, args ...interface{}) {
-	fmt.Fprintf(os.Stdout, fmt.Sprintf("\n\u001B[0;32m✓\u001B[0m %s\n", msg), args...)
+	_, _ = fmt.Fprintf(os.Stdout, fmt.Sprintf("\n\u001B[0;32m✓\u001B[0m %s\n", msg), args...)
 }
 
 // Warn prints warning message in stderr.
 func Warn(msg string, args ...interface{}) {
-	fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;33m%s\u001B[0m\n", msg), args...)
+	_, _ = fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;33m%s\u001B[0m\n", msg), args...)
 }
 
 // Fail prints failure message in stderr.
 func Fail(msg string, args ...interface{}) {
-	fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;31m✗\u001B[0m %s\n", msg), args...)
+	_, _ = fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;31m✗\u001B[0m %s\n", msg), args...)
 }
 
 // Failed prints failure message in stderr and exits.

internal/config/generator.go

@@ -616,7 +616,7 @@ func (c *JiraCLIConfigGenerator) searchAndAssignBoard(project, keyword string) e
 func (c *JiraCLIConfigGenerator) configureMetadata() error {
 	var err error
 
-	//nolint:gomnd
+	//nolint:mnd
 	isV9Compatible := c.value.version.major >= 9 || (c.value.version.major == 8 && c.value.version.minor > 4)
 	if c.value.installation == jira.InstallationTypeLocal && isV9Compatible {
 		err = c.configureIssueTypesForJiraServerV9()

internal/view/board.go

@@ -46,7 +46,7 @@ func (b Board) Render() error {
 	b.printHeader()
 
 	for _, d := range b.data {
-		fmt.Fprintf(b.writer, "%d\t%s\t%s\n", d.ID, prepareTitle(d.Name), d.Type)
+		_, _ = fmt.Fprintf(b.writer, "%d\t%s\t%s\n", d.ID, prepareTitle(d.Name), d.Type)
 	}
 	if _, ok := b.writer.(*tabwriter.Writer); ok {
 		err := b.writer.(*tabwriter.Writer).Flush()
@@ -69,10 +69,10 @@ func (b Board) header() []string {
 func (b Board) printHeader() {
 	n := len(b.header())
 	for i, h := range b.header() {
-		fmt.Fprintf(b.writer, "%s", h)
+		_, _ = fmt.Fprintf(b.writer, "%s", h)
 		if i != n-1 {
-			fmt.Fprintf(b.writer, "\t")
+			_, _ = fmt.Fprintf(b.writer, "\t")
 		}
 	}
-	fmt.Fprintln(b.writer, "")
+	_, _ = fmt.Fprintln(b.writer, "")
 }

internal/view/helper.go

@@ -141,19 +141,19 @@ func jiraURLFromTuiData(server string, r int, d interface{}) string {
 }
 
 func navigate(server string) tui.SelectedFunc {
-	return func(r, c int, d interface{}) {
+	return func(r, _ int, d interface{}) {
 		_ = browser.Browse(jiraURLFromTuiData(server, r, d))
 	}
 }
 
 func copyURL(server string) tui.CopyFunc {
-	return func(r, c int, d interface{}) {
+	return func(r, _ int, d interface{}) {
 		_ = clipboard.WriteAll(jiraURLFromTuiData(server, r, d))
 	}
 }
 
 func copyKey() tui.CopyKeyFunc {
-	return func(r, c int, d interface{}) {
+	return func(r, _ int, d interface{}) {
 		_ = clipboard.WriteAll(issueKeyFromTuiData(r, d))
 	}
 }
@@ -162,12 +162,12 @@ func renderPlain(w io.Writer, data tui.TableData) error {
 	for _, items := range data {
 		n := len(items)
 		for j, v := range items {
-			fmt.Fprintf(w, "%s", v)
+			_, _ = fmt.Fprintf(w, "%s", v)
 			if j != n-1 {
-				fmt.Fprintf(w, "\t")
+				_, _ = fmt.Fprintf(w, "\t")
 			}
 		}
-		fmt.Fprintln(w)
+		_, _ = fmt.Fprintln(w)
 	}
 
 	if _, ok := w.(*tabwriter.Writer); ok {

internal/view/project.go

@@ -46,7 +46,7 @@ func (p Project) Render() error {
 	p.printHeader()
 
 	for _, d := range p.data {
-		fmt.Fprintf(p.writer, "%s\t%s\t%s\t%s\n", d.Key, prepareTitle(d.Name), d.Type, d.Lead.Name)
+		_, _ = fmt.Fprintf(p.writer, "%s\t%s\t%s\t%s\n", d.Key, prepareTitle(d.Name), d.Type, d.Lead.Name)
 	}
 	if _, ok := p.writer.(*tabwriter.Writer); ok {
 		err := p.writer.(*tabwriter.Writer).Flush()
@@ -71,10 +71,10 @@ func (p Project) printHeader() {
 	headers := p.header()
 	end := len(headers) - 1
 	for i, h := range headers {
-		fmt.Fprintf(p.writer, "%s", h)
+		_, _ = fmt.Fprintf(p.writer, "%s", h)
 		if i != end {
-			fmt.Fprintf(p.writer, "\t")
+			_, _ = fmt.Fprintf(p.writer, "\t")
 		}
 	}
-	fmt.Fprintln(p.writer)
+	_, _ = fmt.Fprintln(p.writer)
 }

internal/view/serverinfo.go

@@ -43,7 +43,7 @@ func WithServerInfoWriter(w io.Writer) ServerInfoOption {
 
 // Render renders the serverinfo view.
 func (s ServerInfo) Render() error {
-	fmt.Fprintf(s.writer, `SERVER INFO
+	_, _ = fmt.Fprintf(s.writer, `SERVER INFO
 -----------
 
 Version: 	 %s