Fix nxos integration tests (#1014)

* Fix nxos_facts and update delegate_to

* chore: auto fixes from pre-commit.com hooks

* temporary disable file copy tests

* check again: fix l3_intf

* fix for snmp and nxos_user

* chore: auto fixes from pre-commit.com hooks

* Remove debugpy

* make it to lower case

* fix bgp_global sanity

* nxos tests config fix

* Fix nxos tests

* increased timeout

* fix_snmp_server tc for network_cli

* chore: auto fixes from pre-commit.com hooks

* remove timeout

* fix ospfv2, ospfv3 and snmp tcs

* chore: auto fixes from pre-commit.com hooks

* Update conn timeout

* fix l3 and add snmp assertions

* removed command length assertion

* nxapi and l3 tc fix

* l3 tc fix

* fix tc

* increasing timeout for httpapi due to connection failures

* increasing timeout

* enable nxapi check

* asserting if port 80 is enabled after nxapi got disabled is previous test

* changed removal strategy for httpapi

* simplify snmp tests

* chore: auto fixes from pre-commit.com hooks

* Disable snmp temp

* chore: auto fixes from pre-commit.com hooks

* Handle ospf tests

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikhil Bhasin <nikhilbhasin7@gmail.com>

Author: 3 people

changelogs/fragments/fix_tests.yaml

@@ -0,0 +1,4 @@
+bugfixes:
+  - cisco.nxos.nxos_facts - Fix handling of facts for httapi type connection.
+trivial:
+  - Fix integration tests.

plugins/cliconf/nxos.py

@@ -377,6 +377,7 @@ def pull_file(self, command, remotepassword=None):
             re.compile(rb"(?i)Too many authentication failures"),
             re.compile(rb"Access Denied"),
             re.compile(rb"(?i)Copying to\/from this server name is not permitted"),
+            re.compile(rb"Could not resolve hostname"),
         ]
 
         # set error regex for copy command

plugins/module_utils/network/nxos/facts/legacy/base.py

@@ -36,7 +36,7 @@ def populate(self):
 
     def run(self, command, output="text"):
         command_string = command
-        if output == "json":
+        if output == "json" and self.capabilities.get("network_api") != "nxapi":
             # Not all devices support | json-pretty but is a workaround for
             # libssh issue https://github.com/ansible/pylibssh/issues/208
             output = "json-pretty"

plugins/module_utils/network/nxos/rm_templates/l3_interfaces.py

@@ -120,7 +120,7 @@ def __init__(self, lines=None, module=None):
             "setval": "ip address"
             "{{ ' ' + ipv4.address.address if ipv4.address.address is defined else '' }}"
             "{{ ' ' + ipv4.address.ip_network_mask if ipv4.address.ip_network_mask is defined else '' }}"
-            "{{ ' secondary' if ipv4.address.secondary is defined else '' }}"
+            "{{ ' secondary' if ipv4.address.secondary | default(False) else '' }}"
             "{{ ' route-preference ' + ipv4.address.route_preference|string"
             " if ipv4.address.route_preference is defined else '' }}"
             "{{ ' tag ' + ipv4.address.tag|string if ipv4.address.tag is defined else '' }}",

tests/integration/labs/inventory.j2

@@ -13,3 +13,4 @@ ansible_httpapi_port={{ ansible_http_port }}
 ansible_become={{ ansible_become | default(true) }}
 ansible_become_password={{ ansible_become_password | default('cisco') }}
 ansible_command_timeout=200
+ansible_connect_timeout=200

tests/integration/targets/nxos_aaa_server/tasks/cli.yaml

@@ -3,14 +3,14 @@
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: test_cases
 
 - name: Collect CLI test cases
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: cli_cases
 
 - name: Set a fact for 'test_cases'

tests/integration/targets/nxos_aaa_server/tasks/nxapi.yaml

@@ -3,14 +3,14 @@
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: test_cases
 
 - name: Collect NX-API test cases
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/nxapi"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: nxapi_cases
 
 - name: Set a fact for 'test_cases'

tests/integration/targets/nxos_aaa_server_host/tasks/cli.yaml

@@ -3,14 +3,14 @@
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: test_cases
 
 - name: Collect CLI test cases
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: cli_cases
 
 - name: Set a fact for 'test_cases'

tests/integration/targets/nxos_aaa_server_host/tasks/nxapi.yaml

@@ -3,14 +3,14 @@
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: test_cases
 
 - name: Collect NX-API test cases
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/nxapi"
     patterns: "{{ testcase }}.yaml"
-  connection: local
+  delegate_to: localhost
   register: nxapi_cases
 
 - name: Set a fact for 'test_cases'

tests/integration/targets/nxos_acl_interfaces/tasks/cli.yaml

@@ -3,14 +3,14 @@
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/common"
     patterns: "{{ testcase }}.yml"
-  connection: local
+  delegate_to: localhost
   register: test_cases
 
 - name: Collect CLI test cases
   ansible.builtin.find:
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yml"
-  connection: local
+  delegate_to: localhost
   register: cli_cases
 
 - name: Set a fact for 'test_cases'