Avoid six (again) (#179)

* Avoid six.

* Add ignores.

Author: felixfontein

changelogs/fragments/179-six.yml

@@ -0,0 +1,3 @@
+bugfixes:
+  - Avoid using ``ansible.module_utils.six`` in more places to avoid deprecation warnings with
+    ansible-core 2.20 (https://github.com/ansible-collections/community.hrobot/pull/179).

plugins/module_utils/robot.py

@@ -10,9 +10,14 @@
 import sys
 
 from ansible.module_utils.common.text.converters import to_native
-from ansible.module_utils.six.moves.urllib.error import HTTPError
 from ansible.module_utils.urls import fetch_url, open_url
 
+try:
+    from urllib.error import HTTPError
+except ImportError:
+    # Python 2.x fallback:
+    from urllib2 import HTTPError
+
 import json
 import time
 

tests/sanity/ignore-2.14.txt

@@ -1,2 +1,3 @@
 plugins/inventory/robot.py yamllint:unparsable-with-libyaml
+plugins/module_utils/robot.py pylint:ansible-bad-import-from
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang

tests/sanity/ignore-2.15.txt

@@ -1,3 +1,4 @@
 plugins/inventory/robot.py yamllint:unparsable-with-libyaml
+plugins/module_utils/robot.py pylint:ansible-bad-import-from
 plugins/modules/storagebox_snapshot_plan.py pylint:unbalanced-dict-unpacking  # only seems to be a problem with pylint included in ansible-core 2.15
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang

tests/sanity/ignore-2.16.txt

@@ -1,2 +1,3 @@
 plugins/inventory/robot.py yamllint:unparsable-with-libyaml
+plugins/module_utils/robot.py pylint:ansible-bad-import-from
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang

tests/sanity/ignore-2.17.txt

@@ -1 +1,2 @@
+plugins/module_utils/robot.py pylint:ansible-bad-import-from
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang

tests/sanity/ignore-2.18.txt

@@ -1 +1,2 @@
+plugins/module_utils/robot.py pylint:ansible-bad-import-from
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang

tests/sanity/ignore-2.19.txt

@@ -1 +1,2 @@
+plugins/module_utils/robot.py pylint:ansible-bad-import-from
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang

tests/sanity/ignore-2.20.txt

@@ -1 +1,2 @@
+plugins/module_utils/robot.py pylint:ansible-bad-import-from  # we should not use six, but we also shouldn't use the import from the Python std lib... please decide!
 tests/ee/roles/smoke/library/smoke_ipaddress.py shebang