Declared proxy_mode as deprecated, updated quarkus and realm readme #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # deprecated: proxy address forwarding mode if the server is behind a reverse proxy. [none, edge, reencrypt, passthrough] | ||
| keycloak_quarkus_proxy_mode: edge | ||
| keycloak_quarkus_proxy_mode: none |
Member
There was a problem hiding this comment.
please update meta/argument_specs.yml as well
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing that out, now I also changed it there. :)
Member
|
@fxwgr Can you please rebase the PR? We have added new CI jobs wanted to confirm before merging it. |
Contributor
Author
|
@RanabirChakraborty Done as requested :) |
RanabirChakraborty
added
the
major_changes
Member
|
@fxwgr one more request before i merge, can you please make one commit instead of two separate ones. As both of the commits solve the same issue. |
Updated argument_specs and declared keycloak_quarkus_proxy_mode as deprecated
Contributor
Author
|
Sorry, I missed your last comment, now I squashed the commits into one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declared proxy_mode as deprecated and changed it to
noneby default according to https://www.keycloak.org/docs/latest/release_notes/index.html#proxy-option-removed.Added link https://www.keycloak.org/server/all-config to
keycloak_quarkus_additional_env_varsas reference to quarkus readme.Fixed typos.