add tests for ad-hoc commands for regular and smart inventories (#2584)

Author: RedOrNot

cypress/e2e/awx/resources/inventoryHost/inventoryHostRegular.cy.ts

@@ -1,10 +1,15 @@
+import { awxAPI } from '../../../../../frontend/awx/common/api/awx-utils';
 import { Inventory } from '../../../../../frontend/awx/interfaces/Inventory';
 import { Organization } from '../../../../../frontend/awx/interfaces/Organization';
 import { AwxUser } from '../../../../../frontend/awx/interfaces/User';
+import { runCommand } from './runCommandFunction';
+import { randomString } from '../../../../../framework/utils/random-string';
+
 import {
   checkHostGroup,
   createAndEditAndDeleteHost,
   testHostBulkDelete,
+  createHost,
 } from '../../../../support/hostsfunctions';
 
 describe('Inventory Host Tab Tests for regular inventory', () => {
@@ -80,19 +85,75 @@ describe('Inventory Host Tab Tests for regular inventory', () => {
     //5) Cancel the job and assert that it has been canceled
   });
 
-  it.skip(`can run an ad-hoc command against a host on the inventory hosts tab`, () => {
+  it(`can run an ad-hoc command against a host on the inventory hosts tab`, () => {
     //1) Use the inventory created in before, access the host tab of that inventory
     //2) Use a host, EE, and credential - these resources are needed to run a command against a host
     //3) Assert redirect to the job output screen
     //4) Navigate to the details page of the job and assert the values there match what was entered in the Run Command Wizard
     //5) Navigate back to the Inventory -> Jobs Tab to assert that the Run Command job shows up there
+    createHost('inventory_host', inventory.id);
+
+    cy.navigateTo('awx', 'inventories');
+    cy.intercept('get', awxAPI`/inventories/?name=${inventory.name}*`).as('getInventories');
+    cy.filterTableByMultiSelect('name', [inventory.name]);
+    cy.wait('@getInventories');
+
+    cy.contains('a', inventory.name).click();
+    cy.contains(`a[role="tab"]`, 'Hosts').click();
+
+    cy.getByDataCy('run-command').click();
+
+    runCommand({
+      selections: 'all',
+      module: 'shell',
+      verbosity: '0-(normal)',
+      forks: 2,
+      show_changes: true,
+      become_enabled: true,
+      organization,
+    });
   });
 
-  it.skip('can run an ad-hoc command against the host on the groups tab of a host-inventory from the host details page', () => {
+  it('can run an ad-hoc command against the host on the groups tab of a host-inventory from the host details page', () => {
     //1) Use the inventory created in before, access the host tab of that inventory, visit the host details page
     //2) Use a host, EE, and credential - these resources are needed to run a command against a host
     //3) Assert redirect to the job output screen
     //4) Navigate to the details page of the job and assert the values there match what was entered in the Run Command Wizard
     //5) Navigate back to the Inventory -> Jobs Tab to assert that the Run Command job shows up there
+
+    createHost('inventory_host', inventory.id);
+    const groupName = 'E2E group ' + randomString(4);
+    cy.createInventoryGroup(inventory, groupName);
+    cy.log(`inv: ${inventory.name}, group: ${groupName}`);
+
+    cy.navigateTo('awx', 'inventories');
+
+    cy.intercept('get', awxAPI`/inventories/?name=${inventory.name}*`).as('getInventories');
+    cy.filterTableByMultiSelect('name', [inventory.name]);
+    cy.wait('@getInventories');
+
+    cy.contains('a', inventory.name).click();
+
+    cy.contains(`a[role="tab"]`, 'Groups').click();
+    cy.reload();
+    cy.contains('a', groupName).click();
+
+    cy.contains(`a[role="tab"]`, 'Hosts').click();
+    // add existing host
+    cy.getByDataCy('add-existing-host').click();
+    cy.getByDataCy('select-all').click();
+    cy.clickModalButton('Add hosts');
+
+    cy.getByDataCy('run-command').click();
+
+    runCommand({
+      selections: 'all',
+      module: 'shell',
+      verbosity: '0-(normal)',
+      forks: 2,
+      show_changes: true,
+      become_enabled: true,
+      organization,
+    });
   });
 });

cypress/e2e/awx/resources/inventoryHost/inventoryHostSmart.cy.ts

@@ -1,7 +1,9 @@
 /* eslint-disable @typescript-eslint/no-unsafe-call */
+import { awxAPI } from '../../../../../frontend/awx/common/api/awx-utils';
 import { Inventory } from '../../../../../frontend/awx/interfaces/Inventory';
 import { Organization } from '../../../../../frontend/awx/interfaces/Organization';
 import { AwxUser } from '../../../../../frontend/awx/interfaces/User';
+import { runCommand } from './runCommandFunction';
 import { checkHiddenButton, checkHiddenTab } from '../../../../support/hostsfunctions';
 
 describe('Inventory Host Tab Tests for smart inventory', () => {
@@ -16,6 +18,7 @@ describe('Inventory Host Tab Tests for smart inventory', () => {
         const { inventory: inv } = result;
         inventory = inv;
       });
+
       cy.createAwxUser(organization).then((testUser) => {
         user = testUser;
       });
@@ -29,14 +32,34 @@ describe('Inventory Host Tab Tests for smart inventory', () => {
   });
 
   //tests
-  it.skip(`can run an ad-hoc command against a host on the inventory hosts tab`, () => {
+  it(`can run an ad-hoc command against a host on the inventory hosts tab`, () => {
     //1) Use the inventory created in before, access the host tab of that inventory
     //2) Use a host, EE, and credential - these resources are needed to run a command against a host
     //3) Assert redirect to the job output screen
     //4) Navigate to the details page of the job and assert the values there match what was entered in the Run Command Wizard
     //5) Navigate back to the Inventory -> Jobs Tab to assert that the Run Command job shows up there
+    cy.navigateTo('awx', 'inventories');
+    cy.intercept('get', awxAPI`/inventories/?name=${inventory.name}*`).as('getInventories');
+    cy.filterTableByMultiSelect('name', [inventory.name]);
+    cy.wait('@getInventories');
+
+    cy.contains('a', inventory.name).click();
+    cy.contains(`a[role="tab"]`, 'Hosts').click();
+
+    cy.getByDataCy('run-command').click();
+
+    runCommand({
+      selections: 'all',
+      module: 'shell',
+      verbosity: '0-(normal)',
+      forks: 2,
+      show_changes: true,
+      become_enabled: true,
+      organization,
+    });
   });
 
+  //there is NO group tab in smart inventory
   it.skip('can run an ad-hoc command against the host on the groups tab of a host-inventory from the host details page', () => {
     //1) Use the inventory created in before, access the host tab of that inventory, visit the host details page
     //2) Use a host, EE, and credential - these resources are needed to run a command against a host

cypress/support/hostsfunctions.ts

@@ -45,7 +45,7 @@ export function createAndCheckHost(host_type: string, inventory: string) {
   return hostName;
 }
 
-function createHost(host_type: string, inventoryID: number) {
+export function createHost(host_type: string, inventoryID: number) {
   const hostName = 'E2E Host ' + randomString(4);
   // create host with no verify
   if (host_type === 'inventory_host') {
@@ -126,7 +126,7 @@ function navigateToHost(host_type: string, name: string, data: string, inventory
   cy.get(data).click();
 }
 
-function navigateToBaseView(host_type: string, inventoryName: string) {
+export function navigateToBaseView(host_type: string, inventoryName: string) {
   //function for navigeate to host list view or inventory host list view
   if (host_type === 'inventory_host') {
     cy.navigateTo('awx', 'inventories');