`use_picker` vs `use_mesh`

[germa89]

Current entity picking method uses use_mesh argument.

This argument is being deprecated as stated in:

https://github.com/pyvista/pyvista/blob/8d2620ec412776e051afe72e6e9cb51662d1bd0e/pyvista/plotting/picking.py#L475

Replacing one by the other is not as straightforward as I would have thought. Since these are the only warnings raised in the testing, I am creating this issue so I can address it when I have more time.

Related to #3934

[germa89]

Ping @AlejandroFernandezLuces for feedback on this.

[AlejandroFernandezLuces]

May I ask what difficulties have you found while doing the replacement? I'm not seeing why you would have issues with it.

[germa89]

It basically changed the layout of the plot... somehow....

I didnt really spent much on it. If I just replace one by another, the picking tests fails probably because I need to specify a picker or similar.

[germa89]

I must say the testing of the picking is not very robust. If you have done/seen something about testing picking, please drop some links! :)

[AlejandroFernandezLuces]

Picker examples: https://visualization-interface.tools.docs.pyansys.com/version/stable/examples/00-basic-pyvista-examples/picker.html#activate-the-picker

When the window is closed, you should get the list of the picked elements: https://github.com/ansys/ansys-tools-visualization-interface/blob/f20c08302df5b8dd4b0c8d6c9bb2e6d90e799835/src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py#L463-L466

I'll check in the visualization tool if these functionalities are working fine.

PyAnsys

Activate the picker — Visualization Interface Tool

GitHub

ansys-tools-visualization-interface/src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py at f20c08302df5b8dd4b0c8d6c9bb2e6d90e799835 · ansys/ansys-tools-visualization-interface

A common visualizer for PyAnsys libraries. Contribute to ansys/ansys-tools-visualization-interface development by creating an account on GitHub.

[AlejandroFernandezLuces]

There was a missing return in the viz tool that caused the picked items list to be always empty. Fixed in this PR:

ansys/ansys-tools-visualization-interface#352

And now most interactions are being tested, so hopefully we will get less surprises 😄

[germa89]

Related:

I'm disabling a picking tests in #4220 so I can update Pyvista.

The traceback is the following:

=========================================================================== FAILURES ===========================================================================
_______________________________________________________________________ test_pick_kp[S] ________________________________________________________________________

mapdl = <ansys.mapdl.core.mapdl_grpc.MapdlGrpc object at 0x7f5528ebdd90>, make_block = None, selection = 'S'

    @pytest.mark.parametrize(
        "selection",
        ["S", "R", "A", "U"],
    )
    def test_pick_kp(mapdl, make_block, selection):
        # Cleaning the model a bit
        mapdl.modmsh("detach")  # detaching geom and fem
        mapdl.vdele("all")
        mapdl.adele("all")
        mapdl.ldele("all")
        mapdl.ksel("u", "kp", "", 1)
        mapdl.ksel("u", "kp", "", 2)
        mapdl.kdele("all")
        mapdl.ksel("all")
    
        def debug_orders(pl, point):
            pl = pl.scene
            pl.show(auto_close=False)
            pl.window_size = (100, 100)
            width, height = pl.window_size
            if pl._picking_right_clicking_observer is None:
                pl.iren._mouse_left_button_press(
                    int(width * point[0]), int(height * point[1])
                )
                pl.iren._mouse_left_button_release(width, height)
            else:
                pl.iren._mouse_right_button_press(
                    int(width * point[0]), int(height * point[1])
                )
                pl.iren._mouse_right_button_release(width, height)
    
            pl.iren._mouse_move(int(width * point[0]), int(height * point[1]))
    
        mapdl.ksel("S", "KP", "", 1)
        if selection == "R" or selection == "U":
            point = (285 / 1024, 280 / 800)
            mapdl.ksel("a", "kp", "", 2)  # Selects node 2
        elif selection == "A":
            point = (285 / 1024, 280 / 800)
        else:
            point = (0.5, 0.5)
    
        selected = mapdl.ksel(
            selection,
            "P",
            _debug=lambda x: debug_orders(x, point=point),
            tolerance=1.0,
        )
    
        assert isinstance(selected, (list, np.ndarray))
        if isinstance(selected, np.ndarray):
            assert selected.all()
        else:
            assert selected
        assert len(selected) > 0
        if selection != "U":
            assert sorted(selected) == sorted(mapdl._get_selected_("kp"))
    
        if selection == "S":
>           assert selected == [1]
E           assert array([2]) == [1]
E             
E             Full diff:
E             + array([2])
E             - [
E             -     1,
E             - ]

tests/test_plotting.py:679: AssertionError