Skip to content

Changing import_stackup to handle filename from argument #8

@oskarvh

Description

@oskarvh

Hi,
First of all, awesome work, I'm currently using your project inside of another python script, so I'm not using it directly from the command line. But I was super excited when I found this repo!

Hence, I do want to have some flexibility when it comes to the placement of files. First snag I hit was the assumption that the stackup.json file is found under fab/stackup.json. This is generally not an issue but I've opened a PR to put this as a default argument instead of a constant in the function.

I couldn't find any more issues, but if I do I'll try to fix them and contribute back.

Link to PR: #7

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions