fix(AllowListPlugin): Safely handle default allow navigation policy in allow request (#1342)

jskrepnek · web-flow · commit aea6b7f6f474 · 2021-09-09T14:58:58.000+09:00
diff --git a/framework/src/org/apache/cordova/AllowListPlugin.java b/framework/src/org/apache/cordova/AllowListPlugin.java
@@ -122,7 +122,7 @@ public Boolean shouldAllowNavigation(String url) {
 
     @Override
     public Boolean shouldAllowRequest(String url) {
-        return (this.shouldAllowNavigation(url) || this.allowedRequests.isUrlAllowListed(url))
+        return (Boolean.TRUE.equals(this.shouldAllowNavigation(url)) || this.allowedRequests.isUrlAllowListed(url))
             ? true
             : null; // default policy
     }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ public Boolean shouldAllowNavigation(String url) {`
`122`	`122`
`123`	`123`	`@Override`
`124`	`124`	`public Boolean shouldAllowRequest(String url) {`
`125`		`- return (this.shouldAllowNavigation(url) \|\| this.allowedRequests.isUrlAllowListed(url))`
	`125`	`+ return (Boolean.TRUE.equals(this.shouldAllowNavigation(url)) \|\| this.allowedRequests.isUrlAllowListed(url))`
`126`	`126`	`? true`
`127`	`127`	`: null; // default policy`
`128`	`128`	`}`