feat(spark): set the signature to be taking exactly one Date32 type

Signed-off-by: Alan Tang <jmtangcs@gmail.com>

Author: Standing-Man

datafusion/spark/src/function/datetime/last_day.rs

@@ -21,8 +21,7 @@ use std::sync::Arc;
 use arrow::array::{ArrayRef, AsArray, Date32Array};
 use arrow::datatypes::{DataType, Date32Type};
 use chrono::{Datelike, Duration, NaiveDate};
-use datafusion_common::types::NativeType;
-use datafusion_common::{exec_datafusion_err, exec_err, plan_err, Result, ScalarValue};
+use datafusion_common::{exec_datafusion_err, internal_err, Result, ScalarValue};
 use datafusion_expr::{
     ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, Volatility,
 };
@@ -41,7 +40,7 @@ impl Default for SparkLastDay {
 impl SparkLastDay {
     pub fn new() -> Self {
         Self {
-            signature: Signature::user_defined(Volatility::Immutable),
+            signature: Signature::exact(vec![DataType::Date32], Volatility::Immutable),
         }
     }
 }
@@ -66,7 +65,7 @@ impl ScalarUDFImpl for SparkLastDay {
     fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> {
         let ScalarFunctionArgs { args, .. } = args;
         let [arg] = args.as_slice() else {
-            return exec_err!(
+            return internal_err!(
                 "Spark `last_day` function requires 1 argument, got {}",
                 args.len()
             );
@@ -91,33 +90,14 @@ impl ScalarUDFImpl for SparkLastDay {
                         Ok(Arc::new(result) as ArrayRef)
                     }
                     other => {
-                        exec_err!("Unsupported data type {other:?} for Spark function `last_day`")
+                        internal_err!("Unsupported data type {other:?} for Spark function `last_day`")
                     }
                 }?;
                 Ok(ColumnarValue::Array(result))
             }
-            other => exec_err!("Unsupported arg {other:?} for Spark function `last_day"),
-        }
-    }
-
-    fn coerce_types(&self, arg_types: &[DataType]) -> Result<Vec<DataType>> {
-        if arg_types.len() != 1 {
-            return exec_err!(
-                "Spark `last_day` function requires 1 argument, got {}",
-                arg_types.len()
-            );
-        }
-
-        let current_native_type: NativeType = (&arg_types[0]).into();
-        if matches!(current_native_type, NativeType::Date)
-            || matches!(current_native_type, NativeType::String)
-            || matches!(current_native_type, NativeType::Null)
-        {
-            Ok(vec![DataType::Date32])
-        } else {
-            plan_err!(
-                "The first argument of the Spark `last_day` function can only be a date or string, but got {}", &arg_types[0]
-            )
+            other => {
+                internal_err!("Unsupported arg {other:?} for Spark function `last_day")
+            }
         }
     }
 }

datafusion/sqllogictest/test_files/spark/datetime/last_day.slt

@@ -22,79 +22,79 @@
 #   https://github.com/apache/datafusion/issues/15914
 
 query D
-SELECT last_day('2009-01-12'::string);
+SELECT last_day('2009-01-12'::DATE);
 ----
 2009-01-31
 
 
 query D
-SELECT last_day('2015-02-28'::string);
+SELECT last_day('2015-02-28'::DATE);
 ----
 2015-02-28
 
 query D
-SELECT last_day('2015-03-27'::string);
+SELECT last_day('2015-03-27'::DATE);
 ----
 2015-03-31
 
 query D
-SELECT last_day('2015-04-26'::string);
+SELECT last_day('2015-04-26'::DATE);
 ----
 2015-04-30
 
 query D
-SELECT last_day('2015-05-25'::string);
+SELECT last_day('2015-05-25'::DATE);
 ----
 2015-05-31
 
 query D
-SELECT last_day('2015-06-24'::string);
+SELECT last_day('2015-06-24'::DATE);
 ----
 2015-06-30
 
 query D
-SELECT last_day('2015-07-23'::string);
+SELECT last_day('2015-07-23'::DATE);
 ----
 2015-07-31
 
 query D
-SELECT last_day('2015-08-01'::string);
+SELECT last_day('2015-08-01'::DATE);
 ----
 2015-08-31
 
 query D
-SELECT last_day('2015-09-02'::string);
+SELECT last_day('2015-09-02'::DATE);
 ----
 2015-09-30
 
 query D
-SELECT last_day('2015-10-03'::string);
+SELECT last_day('2015-10-03'::DATE);
 ----
 2015-10-31
 
 query D
-SELECT last_day('2015-11-04'::string);
+SELECT last_day('2015-11-04'::DATE);
 ----
 2015-11-30
 
 query D
-SELECT last_day('2015-12-05'::string);
+SELECT last_day('2015-12-05'::DATE);
 ----
 2015-12-31
 
 
 query D
-SELECT last_day('2016-01-06'::string);
+SELECT last_day('2016-01-06'::DATE);
 ----
 2016-01-31
 
 query D
-SELECT last_day('2016-02-07'::string);
+SELECT last_day('2016-02-07'::DATE);
 ----
 2016-02-29
 
 
-query ?
-SELECT NULL;
+query D
+SELECT last_day(null::DATE);
 ----
-NULL
+NULL