Remove unused as_any method from schema adapter implementations

Author: kosiew

datafusion/core/src/datasource/listing/table.rs

@@ -2912,10 +2912,6 @@ mod tests {
                 error_type: self.error_type,
             })
         }
-
-        fn as_any(&self) -> &dyn Any {
-            self
-        }
     }
 
     #[derive(Debug)]
@@ -2964,10 +2960,6 @@ mod tests {
                 schema: projected_table_schema,
             })
         }
-
-        fn as_any(&self) -> &dyn Any {
-            self
-        }
     }
 
     #[derive(Debug)]

datafusion/core/src/datasource/mod.rs

@@ -71,7 +71,7 @@ mod tests {
     };
     use datafusion_datasource_parquet::source::ParquetSource;
     use datafusion_physical_plan::collect;
-    use std::{any::Any, fs, sync::Arc};
+    use std::{fs, sync::Arc};
     use tempfile::TempDir;
 
     #[tokio::test]
@@ -214,10 +214,6 @@ mod tests {
                 table_schema: projected_table_schema,
             })
         }
-
-        fn as_any(&self) -> &dyn Any {
-            self
-        }
     }
 
     struct TestSchemaAdapter {

datafusion/core/tests/parquet/schema_adapter.rs

@@ -15,7 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use std::any::Any;
 use std::sync::Arc;
 
 use arrow::array::{record_batch, RecordBatch, RecordBatchOptions};
@@ -43,15 +42,6 @@ use itertools::Itertools;
 use object_store::{memory::InMemory, path::Path, ObjectStore};
 use parquet::arrow::ArrowWriter;
 
-#[cfg(feature = "parquet")]
-use datafusion::datasource::physical_plan::ParquetSource;
-use datafusion::datasource::physical_plan::{
-    ArrowSource, CsvSource, FileScanConfigBuilder, FileSource, JsonSource,
-};
-use datafusion::datasource::source::DataSourceExec;
-use datafusion::physical_plan::ExecutionPlan;
-use datafusion_datasource::PartitionedFile;
-
 async fn write_parquet(batch: RecordBatch, store: Arc<dyn ObjectStore>, path: &str) {
     let mut out = BytesMut::new().writer();
     {
@@ -76,10 +66,6 @@ impl SchemaAdapterFactory for CustomSchemaAdapterFactory {
             logical_file_schema: projected_table_schema,
         })
     }
-
-    fn as_any(&self) -> &dyn Any {
-        self
-    }
 }
 
 #[derive(Debug)]

datafusion/datasource-parquet/src/opener.rs

@@ -1213,10 +1213,6 @@ mod test {
             ) -> Box<dyn SchemaAdapter> {
                 Box::new(CustomSchemaAdapter)
             }
-
-            fn as_any(&self) -> &dyn std::any::Any {
-                self
-            }
         }
 
         // Test that if no expression rewriter is provided we use a schemaadapter to adapt the data to the expresssion

datafusion/datasource-parquet/tests/apply_schema_adapter_tests.rs

@@ -47,10 +47,6 @@ mod parquet_adapter_tests {
                 prefix: self.prefix.clone(),
             })
         }
-
-        fn as_any(&self) -> &dyn std::any::Any {
-            self
-        }
     }
 
     /// A test schema adapter that adds prefix to column names

datafusion/datasource/src/schema_adapter.rs

@@ -29,7 +29,7 @@ use datafusion_common::{
     nested_struct::{cast_column, validate_struct_compatibility},
     plan_err, ColumnStatistics,
 };
-use std::{any::Any, fmt::Debug, sync::Arc};
+use std::{fmt::Debug, sync::Arc};
 /// Function used by [`SchemaMapping`] to adapt a column from the file schema to
 /// the table schema.
 pub type CastColumnFn =
@@ -68,8 +68,6 @@ pub trait SchemaAdapterFactory: Debug + Send + Sync + 'static {
     ) -> Box<dyn SchemaAdapter> {
         self.create(Arc::clone(&projected_table_schema), projected_table_schema)
     }
-    /// Give us access to Any so callers can downcast.
-    fn as_any(&self) -> &dyn Any;
 }
 
 /// Creates [`SchemaMapper`]s to map file-level [`RecordBatch`]es to a table
@@ -234,10 +232,6 @@ impl SchemaAdapterFactory for DefaultSchemaAdapterFactory {
             projected_table_schema,
         })
     }
-
-    fn as_any(&self) -> &dyn Any {
-        self
-    }
 }
 
 /// This SchemaAdapter requires both the table schema and the projected table