Skip to content

Commit d375bfe

Browse files
authored
Remove the "extended workflow" github action (#17119)
1 parent ff77b70 commit d375bfe

File tree

3 files changed

+6
-139
lines changed

3 files changed

+6
-139
lines changed

.github/workflows/extended.yml

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -159,44 +159,6 @@ jobs:
159159
cargo test --features backtrace --profile release-nonlto --test sqllogictests -- --include-sqlite
160160
cargo clean
161161
162-
# If the workflow was triggered by the PR comment (through pr_comment_commands.yml action) we need to manually update check status to display in UI
163-
update-check-status:
164-
needs: [linux-build-lib, linux-test-extended, hash-collisions, sqllogictest-sqlite]
165-
runs-on: ubuntu-latest
166-
if: ${{ always() && github.event_name == 'workflow_dispatch' }}
167-
steps:
168-
- name: Determine workflow status
169-
id: status
170-
run: |
171-
if [[ "${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}" == "true" ]]; then
172-
echo "workflow_status=failure" >> $GITHUB_OUTPUT
173-
echo "conclusion=failure" >> $GITHUB_OUTPUT
174-
else
175-
echo "workflow_status=completed" >> $GITHUB_OUTPUT
176-
echo "conclusion=success" >> $GITHUB_OUTPUT
177-
fi
178-
179-
- name: Update check run
180-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
181-
with:
182-
github-token: ${{ secrets.GITHUB_TOKEN }}
183-
script: |
184-
const workflowRunUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
185-
186-
await github.rest.checks.update({
187-
owner: context.repo.owner,
188-
repo: context.repo.repo,
189-
check_run_id: ${{ github.event.inputs.check_run_id }},
190-
status: 'completed',
191-
conclusion: '${{ steps.status.outputs.conclusion }}',
192-
output: {
193-
title: '${{ steps.status.outputs.conclusion == 'success' && 'Extended Tests Passed' || 'Extended Tests Failed' }}',
194-
summary: `Extended tests have completed with status: ${{ steps.status.outputs.conclusion }}.\n\n[View workflow run](${workflowRunUrl})`
195-
},
196-
details_url: workflowRunUrl
197-
});
198-
199-
200162
201163
202164

.github/workflows/pr_comment_commands.yml

Lines changed: 0 additions & 89 deletions
This file was deleted.

docs/source/contributor-guide/testing.md

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,23 +75,17 @@ cargo insta review
7575
In addition to the standard CI test suite that is run on all PRs prior to merge,
7676
DataFusion has "extended" tests (defined in [extended.yml]) that are run on each
7777
commit to `main`. These tests rarely fail but take significantly longer to run
78-
than the standard test suite and add important test coverage such as that the
79-
code works when there are hash collisions as well as running the relevant
80-
portions of the entire [sqlite test suite].
78+
than the standard test suite and add important test coverage such as ensuring
79+
correctness when there are hash collisions and running the relevant portions of
80+
the entire [sqlite test suite]. You can run the extended tests
81+
locally by following the [instructions in the documentation].
8182

82-
You can run the extended tests on any PR by leaving the following comment (see [example here]):
83-
84-
```
85-
Run extended tests
86-
```
87-
88-
[extended.yml]: https://github.com/apache/datafusion/blob/main/.github/workflows/extended.yml
8983
[sqlite test suite]: https://www.sqlite.org/sqllogictest/dir?ci=tip
90-
[example here]: https://github.com/apache/datafusion/pull/15427#issuecomment-2759160812
84+
[instructions in the documentation]: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite
9185

9286
## Rust Integration Tests
9387

94-
There are several tests of the public interface of the DataFusion library in the [tests](https://github.com/apache/datafusion/tree/main/datafusion/core/tests) directory.
88+
There are several public interface tests for the DataFusion library in the [tests](https://github.com/apache/datafusion/tree/main/datafusion/core/tests) directory.
9589

9690
You can run these tests individually using `cargo` as normal command such as
9791

0 commit comments

Comments
 (0)