FINERACT-2354: Introduce reaging preview API #5063
Open
+1,982
−537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksii-novikov-onix
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
3 times, most recently
from
8d5cc27 to
61b0528
Compare
|
@oleksii-novikov-onix Please rebase. |
oleksii-novikov-onix
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
from
61b0528 to
377db88
Compare
|
2 tasks
oleksii-novikov-onix
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
from
377db88 to
ff13fb2
Compare
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
2 times, most recently
from
cbb30b1 to
3a8af86
Compare
adamsaghy
reviewed
Oct 27, 2025
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 27, 2025
Comment on lines
2893
to
2904
| AtomicReference<Money> outstandingPrincipalBalance = new AtomicReference<>(Money.zero(currency)); | ||
| final LocalDate startDate = loanTransaction.getLoanReAgeParameter().getStartDate(); | ||
| final LocalDate endDate = calculateReAgedInstallmentEndDate(loanTransaction.getLoanReAgeParameter()); | ||
| final AtomicReference<Money> outstandingPrincipalBalance = new AtomicReference<>(Money.zero(currency)); | ||
| installments.forEach(i -> { | ||
| Money principalOutstanding = i.getPrincipalOutstanding(currency); | ||
| if (principalOutstanding.isGreaterThanZero()) { | ||
| outstandingPrincipalBalance.set(outstandingPrincipalBalance.get().add(principalOutstanding)); | ||
| i.addToPrincipal(loanTransaction.getTransactionDate(), principalOutstanding.negated()); | ||
| final boolean shouldInclude = !i.isAdditional() || i.getDueDate().isBefore(startDate) | ||
| || (!i.getDueDate().isBefore(startDate) && i.getDueDate().isBefore(endDate)); | ||
| if (shouldInclude) { | ||
| Money principalOutstanding = i.getPrincipalOutstanding(currency); | ||
| if (principalOutstanding.isGreaterThanZero()) { | ||
| outstandingPrincipalBalance.set(outstandingPrincipalBalance.get().add(principalOutstanding)); | ||
| i.addToPrincipal(loanTransaction.getTransactionDate(), principalOutstanding.negated()); | ||
| } |
There was a problem hiding this comment.
why do we need these changes?
There was a problem hiding this comment.
It was added to handle negative balances. I will review the logic again
adamsaghy
reviewed
Oct 27, 2025
| @Parameter(hidden = true) final String apiRequestBodyAsJson, @Context final UriInfo uriInfo) { | ||
| final LoanScheduleData result = previewReAgeScheduleInternal(loanId, null, apiRequestBodyAsJson); | ||
| final ApiRequestJsonSerializationSettings settings = this.apiRequestParameterHelper.process(uriInfo.getQueryParameters()); | ||
| return this.loanScheduleToApiJsonSerializer.serialize(settings, result, new HashSet<>()); |
There was a problem hiding this comment.
No need to serialize. Simply return the LoanScheduleData result. Also you can remove the ApiResponses annotation as well in that case.
adamsaghy
reviewed
Oct 27, 2025
| } | ||
| } | ||
|
|
||
| @POST |
There was a problem hiding this comment.
I think GET would be better here. Lets provide the parameters as query params.
adamsaghy
reviewed
Oct 27, 2025
| } | ||
|
|
||
| @Transactional(readOnly = true) | ||
| public LoanScheduleData previewReAge(final Long loanId, final JsonCommand command) { |
There was a problem hiding this comment.
We don't need command. It's a read operation.
adamsaghy
requested changes
Oct 27, 2025
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
from
3a8af86 to
c3b04b9
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
from
c3b04b9 to
5d47942
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2354/introduce-loan-reaging-preview
branch
from
5d47942 to
cc7407d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.