[FLINK-35280] Migrate HBase Sink to use Async Sink API #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateczagany
force-pushed
the
FLINK-35280
branch
from
5ba938c to
9848246
Compare
ferenc-csaky
requested changes
Nov 18, 2025
Contributor
ferenc-csaky
left a comment
ferenc-csaky
left a comment
There was a problem hiding this comment.
Thanks for getting this done! Awesome work, added a couple comments/questions.
...ase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseMutationSerialization.java
Outdated
Show resolved
Hide resolved
...-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/WrappedElementConverter.java
Show resolved
Hide resolved
...tor-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/SerializableMutation.java
Show resolved
Hide resolved
...tor-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/SerializableMutation.java
Outdated
Show resolved
Hide resolved
...-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseWriterAsyncHandler.java
Outdated
Show resolved
Hide resolved
...-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseWriterAsyncHandler.java
Outdated
Show resolved
Hide resolved
...-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseWriterAsyncHandler.java
Outdated
Show resolved
Hide resolved
...-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseWriterAsyncHandler.java
Outdated
Show resolved
Hide resolved
...-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseWriterAsyncHandler.java
Show resolved
Hide resolved
Contributor
Author
|
I have upgraded HBase to 2.6.4, as the IT test was failing because 2.6.3 has been removed from the public repository: https://dlcdn.apache.org/hbase/ |
mateczagany
force-pushed
the
FLINK-35280
branch
from
79ae57d to
1692748
Compare
mateczagany
force-pushed
the
FLINK-35280
branch
from
1692748 to
28c4803
Compare
ferenc-csaky
requested changes
Nov 27, 2025
Contributor
ferenc-csaky
left a comment
ferenc-csaky
left a comment
There was a problem hiding this comment.
Logic LGTM now, I more thing lets add sink.max-request-write-attempts to hbase.md as well.
Contributor
Author
|
Thank you, I forgot about that. |
ferenc-csaky
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBase2DynamicTableFactorySerializableMutationbecauseMutationis not serializablecommons-ioto the shaded JAR because the async version of HBase client needed ittestTableSinkDisabledBufferFlushbecause it was not working without Flink being able to chain all the operators into 1 operator.