[catalog] Fix namespace creation error status (#1248)

dentiny · web-flow · commit 5592841ef76b · 2025-04-26T12:45:40.000+08:00
## Which issue does this PR close? - Closes #1247 ## What changes are included in this PR? According to the [openapi spec](#1247), already existed error should return 409 (Conflict) status code. ## Are these changes tested? I checked with cargo test and doesn't find any breakage.
diff --git a/crates/catalog/rest/src/catalog.rs b/crates/catalog/rest/src/catalog.rs
@@ -403,7 +403,7 @@ impl Catalog for RestCatalog {
                     deserialize_catalog_response::<NamespaceSerde>(http_response).await?;
                 Namespace::try_from(response)
             }
-            StatusCode::NOT_FOUND => Err(Error::new(
+            StatusCode::CONFLICT => Err(Error::new(
                 ErrorKind::Unexpected,
                 "Tried to create a namespace that already exists",
             )),

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ impl Catalog for RestCatalog {`
`403`	`403`	`deserialize_catalog_response::<NamespaceSerde>(http_response).await?;`
`404`	`404`	`Namespace::try_from(response)`
`405`	`405`	`}`
`406`		`- StatusCode::NOT_FOUND => Err(Error::new(`
	`406`	`+ StatusCode::CONFLICT => Err(Error::new(`
`407`	`407`	`ErrorKind::Unexpected,`
`408`	`408`	`"Tried to create a namespace that already exists",`
`409`	`409`	`)),`