Skip to content

Commit e5df166

Browse files
committed
keep a clean pull request related to jackson upgrade
1 parent cad22f6 commit e5df166

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ public void nullToConnect() {
208208
*/
209209
@Test
210210
public void emptyBytesToConnect() {
211-
// This characterizes the messages with empty data when Json schemas are disabled
211+
// This characterizes the messages with empty data when Json schemas is disabled
212212
Map<String, Boolean> props = Collections.singletonMap("schemas.enable", false);
213213
converter.configure(props, true);
214214
SchemaAndValue converted = converter.toConnectData(TOPIC, "".getBytes());
@@ -220,7 +220,7 @@ public void emptyBytesToConnect() {
220220
*/
221221
@Test
222222
public void schemalessWithEmptyFieldValueToConnect() {
223-
// This characterizes the messages with empty data when Json schemas are disabled
223+
// This characterizes the messages with empty data when Json schemas is disabled
224224
Map<String, Boolean> props = Collections.singletonMap("schemas.enable", false);
225225
converter.configure(props, true);
226226
String input = "{ \"a\": \"\", \"b\": null}";
@@ -502,7 +502,7 @@ public void testCacheSchemaToConnectConversion() {
502502
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"boolean\", \"optional\": true }, \"payload\": true }".getBytes());
503503
assertEquals(2, converter.sizeOfToConnectSchemaCache());
504504

505-
// Even equivalent, but different JSON encoding of schema should get different cache entry
505+
// Even equivalent, but different JSON encoding of schema, should get different cache entry
506506
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"boolean\", \"optional\": false }, \"payload\": true }".getBytes());
507507
assertEquals(3, converter.sizeOfToConnectSchemaCache());
508508
}
@@ -788,7 +788,7 @@ public void nullSchemaAndMapToJson() {
788788

789789
@Test
790790
public void nullSchemaAndMapNonStringKeysToJson() {
791-
// This still needs to do conversion of data; null schema means "anything goes". Make sure we mix and match
791+
// This still needs to do conversion of data null schema means "anything goes". Make sure we mix and match
792792
// types to verify conversion still works.
793793
Map<Object, Object> input = new HashMap<>();
794794
input.put("string", 12);
@@ -855,15 +855,15 @@ public void noSchemaToJson() {
855855
public void testCacheSchemaToJsonConversion() {
856856
assertEquals(0, converter.sizeOfFromConnectSchemaCache());
857857

858-
// Repeated conversion of the same schema, even if the schema object is different, should return the same Java
858+
// Repeated conversion of the same schema, even if the schema object is different should return the same Java
859859
// object
860860
converter.fromConnectData(TOPIC, SchemaBuilder.bool().build(), true);
861861
assertEquals(1, converter.sizeOfFromConnectSchemaCache());
862862

863863
converter.fromConnectData(TOPIC, SchemaBuilder.bool().build(), true);
864864
assertEquals(1, converter.sizeOfFromConnectSchemaCache());
865865

866-
// Validate that similar, but different schema correctly returns a different schema.
866+
// Validate that a similar, but different schema correctly returns a different schema.
867867
converter.fromConnectData(TOPIC, SchemaBuilder.bool().optional().build(), true);
868868
assertEquals(2, converter.sizeOfFromConnectSchemaCache());
869869
}

0 commit comments

Comments
 (0)