From 6a898da318aab16f95796ff552e6c11de2d37f75 Mon Sep 17 00:00:00 2001 From: Chirag Wadhwa Date: Wed, 16 Jul 2025 15:16:03 +0530 Subject: [PATCH 1/2] Corrected the logger name in PersisterStateManagerHandler --- .../apache/kafka/coordinator/group/GroupCoordinatorService.java | 2 +- .../kafka/server/share/persister/PersisterStateManager.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java index fdc23d8d3402b..b67c45cef70c6 100644 --- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java +++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java @@ -797,7 +797,7 @@ private CompletableFuture handlePersisterInitia } return performShareGroupStateMetadataInitialize(groupId, topicPartitionMap, defaultResponse); } - log.error("Received error while calling initialize state for {} on persister {}.", groupId, persisterError.code()); + log.error("Received error while calling initialize state for {} on persister, errorCode: {}.", groupId, persisterError.code()); return uninitializeShareGroupState(persisterError, groupId, topicPartitionMap); } diff --git a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java index ccfae329c7b3b..fb715fadf5300 100644 --- a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java +++ b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java @@ -221,7 +221,7 @@ public void setGenerateCallback(Runnable generateCallback) { public abstract class PersisterStateManagerHandler implements RequestCompletionHandler { protected Node coordinatorNode; private final BackoffManager findCoordBackoff; - protected final Logger log = LoggerFactory.getLogger(getClass()); + protected final Logger log = LoggerFactory.getLogger(getClass().getCanonicalName()); private Consumer onCompleteCallback; protected final SharePartitionKey partitionKey; From 8dab6e046d309a0ae329c01d7793e814e64caa5a Mon Sep 17 00:00:00 2001 From: Chirag Wadhwa Date: Thu, 17 Jul 2025 00:00:57 +0530 Subject: [PATCH 2/2] Resolved test failures in PersisterStateManagerTest --- .../server/share/persister/PersisterStateManager.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java index fb715fadf5300..4569455aee17d 100644 --- a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java +++ b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java @@ -221,7 +221,7 @@ public void setGenerateCallback(Runnable generateCallback) { public abstract class PersisterStateManagerHandler implements RequestCompletionHandler { protected Node coordinatorNode; private final BackoffManager findCoordBackoff; - protected final Logger log = LoggerFactory.getLogger(getClass().getCanonicalName()); + protected final Logger log; private Consumer onCompleteCallback; protected final SharePartitionKey partitionKey; @@ -237,6 +237,11 @@ public PersisterStateManagerHandler( this.onCompleteCallback = response -> { }; // noop partitionKey = SharePartitionKey.getInstance(groupId, topicId, partition); + String canonicalName = getClass().getCanonicalName(); + if (canonicalName == null) { + canonicalName = getClass().getName(); + } + log = LoggerFactory.getLogger(canonicalName); } /**