Skip to content

Commit f164515

Browse files
authored
grammar and jacdoc fixes (#1491)
* grammar * more
1 parent fade356 commit f164515

File tree

7 files changed

+62
-63
lines changed

7 files changed

+62
-63
lines changed

src/it/projects/mdep-689-apply-filtering-go-offline-goal/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ under the License.
9595
<configuration>
9696
<excludeGroupIds>skip.this.groupid,skip.this.groupid.too</excludeGroupIds>
9797
<excludeArtifactIds>skip-this-artifact,skip-this-artifact-too</excludeArtifactIds>
98-
<!-- the maven-common-artifact-filters library does not support comma delimited
99-
scope exclusions. only one at a time. the other filters support comma delimited lists-->
98+
<!-- The maven-common-artifact-filters library does not support comma-delimited
99+
scope exclusions, only one at a time. The other filters support comma-delimited lists. -->
100100
<!-- <excludeScope>compile,system</excludeScope> -->
101101
<excludeScope>system</excludeScope>
102102
<excludeTypes>ear</excludeTypes>

src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/ArtifactItem.java

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -36,37 +36,37 @@
3636
*/
3737
public class ArtifactItem implements DependableCoordinate {
3838
/**
39-
* Group ID of Artifact
39+
* Group ID of artifact
4040
*/
4141
@Parameter(required = true)
4242
private String groupId;
4343

4444
/**
45-
* Name of Artifact
45+
* Name of artifact
4646
*/
4747
@Parameter(required = true)
4848
private String artifactId;
4949

5050
/**
51-
* Version of Artifact
51+
* Version of artifact
5252
*/
5353
@Parameter
5454
private String version = null;
5555

5656
/**
57-
* Type of Artifact (War,Jar,etc)
57+
* Type of artifact (War, Jar, etc.)
5858
*/
5959
@Parameter(required = true)
6060
private String type = "jar";
6161

6262
/**
63-
* Classifier for Artifact (tests,sources,etc)
63+
* Classifier for artifact (tests, sources, etc.)
6464
*/
6565
@Parameter
6666
private String classifier;
6767

6868
/**
69-
* Location to use for this Artifact. Overrides default location.
69+
* Location to use for this artifact. Overrides default location.
7070
*/
7171
@Parameter
7272
private File outputDirectory;
@@ -78,7 +78,7 @@ public class ArtifactItem implements DependableCoordinate {
7878
private String destFileName;
7979

8080
/**
81-
* Force Overwrite..this is the one to set in pom
81+
* Force Overwrite. This is the one to set in pom.
8282
*/
8383
private String overWrite;
8484

@@ -114,7 +114,7 @@ public class ArtifactItem implements DependableCoordinate {
114114
private FileMapper[] fileMappers;
115115

116116
/**
117-
* Default ctor.
117+
* Default constructor.
118118
*/
119119
public ArtifactItem() {
120120
// default constructor
@@ -140,82 +140,82 @@ private String filterEmptyString(String in) {
140140
}
141141

142142
/**
143-
* @return Returns the artifactId.
143+
* @return returns the artifact ID
144144
*/
145145
@Override
146146
public String getArtifactId() {
147147
return artifactId;
148148
}
149149

150150
/**
151-
* @param theArtifact The artifactId to set.
151+
* @param theArtifact the artifact ID to set
152152
*/
153153
public void setArtifactId(String theArtifact) {
154154
this.artifactId = filterEmptyString(theArtifact);
155155
}
156156

157157
/**
158-
* @return Returns the groupId.
158+
* @return returns the group ID
159159
*/
160160
@Override
161161
public String getGroupId() {
162162
return groupId;
163163
}
164164

165165
/**
166-
* @param groupId The groupId to set.
166+
* @param groupId the group ID to set
167167
*/
168168
public void setGroupId(String groupId) {
169169
this.groupId = filterEmptyString(groupId);
170170
}
171171

172172
/**
173-
* @return Returns the type.
173+
* @return returns the type
174174
*/
175175
@Override
176176
public String getType() {
177177
return type;
178178
}
179179

180180
/**
181-
* @param type The type to set.
181+
* @param type the type to set
182182
*/
183183
public void setType(String type) {
184184
this.type = filterEmptyString(type);
185185
}
186186

187187
/**
188-
* @return Returns the version.
188+
* @return returns the version
189189
*/
190190
@Override
191191
public String getVersion() {
192192
return version;
193193
}
194194

195195
/**
196-
* @param version The version to set.
196+
* @param version the version to set
197197
*/
198198
public void setVersion(String version) {
199199
this.version = filterEmptyString(version);
200200
}
201201

202202
/**
203-
* @return Returns the base version.
203+
* @return teturns the base version
204204
*/
205205
public String getBaseVersion() {
206206
return ArtifactUtils.toSnapshotVersion(version);
207207
}
208208

209209
/**
210-
* @return Classifier.
210+
* @return Classifier
211211
*/
212212
@Override
213213
public String getClassifier() {
214214
return classifier;
215215
}
216216

217217
/**
218-
* @param classifier Classifier.
218+
* @param classifier classifier
219219
*/
220220
public void setClassifier(String classifier) {
221221
this.classifier = filterEmptyString(classifier);
@@ -231,122 +231,122 @@ public String toString() {
231231
}
232232

233233
/**
234-
* @return Returns the location.
234+
* @return returns the location
235235
*/
236236
public File getOutputDirectory() {
237237
return outputDirectory;
238238
}
239239

240240
/**
241-
* @param outputDirectory The outputDirectory to set.
241+
* @param outputDirectory the outputDirectory to set
242242
*/
243243
public void setOutputDirectory(File outputDirectory) {
244244
this.outputDirectory = outputDirectory;
245245
}
246246

247247
/**
248-
* @return Returns the location.
248+
* @return returns the location
249249
*/
250250
public String getDestFileName() {
251251
return destFileName;
252252
}
253253

254254
/**
255-
* @param destFileName The destFileName to set.
255+
* @param destFileName the destination file name to set
256256
*/
257257
public void setDestFileName(String destFileName) {
258258
this.destFileName = filterEmptyString(destFileName);
259259
}
260260

261261
/**
262-
* @return Returns the needsProcessing.
262+
* @return returns the needsProcessing
263263
*/
264264
public boolean isNeedsProcessing() {
265265
return this.needsProcessing;
266266
}
267267

268268
/**
269-
* @param needsProcessing The needsProcessing to set.
269+
* @param needsProcessing the needsProcessing to set
270270
*/
271271
public void setNeedsProcessing(boolean needsProcessing) {
272272
this.needsProcessing = needsProcessing;
273273
}
274274

275275
/**
276-
* @return Returns the overWriteSnapshots.
276+
* @return teturns the overWriteSnapshots
277277
*/
278278
public String getOverWrite() {
279279
return this.overWrite;
280280
}
281281

282282
/**
283-
* @param overWrite The overWrite to set.
283+
* @param overWrite the overWrite to set
284284
*/
285285
public void setOverWrite(String overWrite) {
286286
this.overWrite = overWrite;
287287
}
288288

289289
/**
290-
* @return Returns the encoding.
290+
* @return returns the encoding
291291
* @since 3.0
292292
*/
293293
public String getEncoding() {
294294
return this.encoding;
295295
}
296296

297297
/**
298-
* @param encoding The encoding to set.
298+
* @param encoding the encoding to set
299299
* @since 3.0
300300
*/
301301
public void setEncoding(String encoding) {
302302
this.encoding = encoding;
303303
}
304304

305305
/**
306-
* @return Returns the artifact.
306+
* @return returns the artifact
307307
*/
308308
public Artifact getArtifact() {
309309
return this.artifact;
310310
}
311311

312312
/**
313-
* @param artifact The artifact to set.
313+
* @param artifact the artifact to set
314314
*/
315315
public void setArtifact(Artifact artifact) {
316316
this.artifact = artifact;
317317
}
318318

319319
/**
320-
* @return Returns a comma separated list of excluded items
320+
* @return returns a comma separated list of excluded items
321321
*/
322322
public String getExcludes() {
323323
return DependencyUtil.cleanToBeTokenizedString(this.excludes);
324324
}
325325

326326
/**
327-
* @param excludes A comma separated list of items to exclude i.e. <code>**\/*.xml, **\/*.properties</code>
327+
* @param excludes a comma separated list of items to exclude; for example, <code>**\/*.xml, **\/*.properties</code>
328328
*/
329329
public void setExcludes(String excludes) {
330330
this.excludes = excludes;
331331
}
332332

333333
/**
334-
* @return Returns a comma separated list of included items
334+
* @return returns a comma separated list of items to include
335335
*/
336336
public String getIncludes() {
337337
return DependencyUtil.cleanToBeTokenizedString(this.includes);
338338
}
339339

340340
/**
341-
* @param includes A comma separated list of items to include i.e. <code>**\/*.xml, **\/*.properties</code>
341+
* @param includes comma separated list of items to include; for example, <code>**\/*.xml, **\/*.properties</code>
342342
*/
343343
public void setIncludes(String includes) {
344344
this.includes = includes;
345345
}
346346

347347
/**
348348
* @return {@link FileMapper}s to be used for rewriting each target path, or {@code null} if no rewriting shall
349-
* happen.
349+
* happen
350350
*
351351
* @since 3.1.2
352352
*/
@@ -356,7 +356,7 @@ public FileMapper[] getFileMappers() {
356356

357357
/**
358358
* @param fileMappers {@link FileMapper}s to be used for rewriting each target path, or {@code null} if no
359-
* rewriting shall happen.
359+
* rewriting shall happen
360360
*
361361
* @since 3.1.2
362362
*/

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ private Set<Artifact> resolve(Set<org.eclipse.aether.artifact.Artifact> artifact
478478
resolverUtil.resolveArtifact(artifact, getProject().getRemoteProjectRepositories());
479479
resolvedArtifacts.add(RepositoryUtils.toArtifact(resolveArtifact));
480480
} catch (ArtifactResolutionException ex) {
481-
// an error occurred during resolution, log it an continue
481+
// an error occurred during resolution, log it and continue
482482
getLog().debug("error resolving: " + artifact, ex);
483483
if (stopOnFailure) {
484484
throw new MojoExecutionException("error resolving: " + artifact, ex);

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractFromDependenciesMojo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,15 @@ public abstract class AbstractFromDependenciesMojo extends AbstractDependencyFil
8383

8484
/**
8585
* Place each type of file in a separate subdirectory. (example /outputDirectory/runtime /outputDirectory/provided
86-
* etc)
86+
* etc.)
8787
*
8888
* @since 2.2
8989
*/
9090
@Parameter(property = "mdep.useSubDirectoryPerScope", defaultValue = "false")
9191
protected boolean useSubDirectoryPerScope;
9292

9393
/**
94-
* Place each type of file in a separate subdirectory. (example /outputDirectory/jars /outputDirectory/wars etc)
94+
* Place each type of file in a separate subdirectory. (example /outputDirectory/jars /outputDirectory/wars etc.)
9595
*
9696
* @since 2.0-alpha-1
9797
*/

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,11 @@ private void installBaseSnapshot(Artifact artifact, ProjectBuildingRequest build
222222
* Copies the Artifact after building the destination file name if overridden. This method also checks if the
223223
* classifier is set and adds it to the destination file name if needed.
224224
*
225-
* @param artifact representing the object to be copied.
226-
* @param removeVersion specifies if the version should be removed from the file name when copying.
227-
* @param prependGroupId specifies if the groupId should be prepend to the file while copying.
228-
* @param theUseBaseVersion specifies if the baseVersion of the artifact should be used instead of the version.
229-
* @throws MojoExecutionException with a message if an error occurs.
225+
* @param artifact the object to be copied
226+
* @param removeVersion specifies if the version should be removed from the file name when copying
227+
* @param prependGroupId specifies if the group ID should be prefixed to the file while copying
228+
* @param theUseBaseVersion specifies if the baseVersion of the artifact should be used instead of the version
229+
* @throws MojoExecutionException with a message if an error occurs
230230
* @see #copyArtifact(Artifact, boolean, boolean, boolean, boolean)
231231
*/
232232
protected void copyArtifact(
@@ -239,12 +239,12 @@ protected void copyArtifact(
239239
* Copies the Artifact after building the destination file name if overridden. This method also checks if the
240240
* classifier is set and adds it to the destination file name if needed.
241241
*
242-
* @param artifact representing the object to be copied.
243-
* @param removeVersion specifies if the version should be removed from the file name when copying.
244-
* @param prependGroupId specifies if the groupId should be prepend to the file while copying.
245-
* @param useBaseVersion specifies if the baseVersion of the artifact should be used instead of the version.
246-
* @param removeClassifier specifies if the classifier should be removed from the file name when copying.
247-
* @throws MojoExecutionException with a message if an error occurs.
242+
* @param artifact the object to be copied
243+
* @param removeVersion specifies if the version should be removed from the file name when copying
244+
* @param prependGroupId specifies if the groupId should be prefixed to the file while copying
245+
* @param useBaseVersion specifies if the baseVersion of the artifact should be used instead of the version
246+
* @param removeClassifier specifies if the classifier should be removed from the file name when copying
247+
* @throws MojoExecutionException with a message if an error occurs
248248
* @see CopyUtil#copyArtifactFile(Artifact, File)
249249
* @see DependencyUtil#getFormattedOutputDirectory(boolean, boolean, boolean, boolean, boolean, boolean, File, Artifact)
250250
*/

src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ private void writeNode(int indent, DependencyNode node, StringBuilder sb, Set<De
8484
}
8585
}
8686
/**
87-
* Writes the children of the node to the string builder. And each children of each node will be written recursively.
87+
* Writes the children of the node to the string builder. Each child of each node will be written recursively.
8888
*
8989
* @param indent the current indent level
9090
* @param node the node to write

0 commit comments

Comments
 (0)