HealthCheckRoutes Provider, so user can add it to their own server #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes and add it to their own server
pjfanning
reviewed
Oct 2, 2024
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Outdated
Show resolved
Hide resolved
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Show resolved
Hide resolved
pjfanning
reviewed
Oct 2, 2024
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Oct 2, 2024
management/src/main/scala/org/apache/pekko/management/HealthCheckRoutes.scala
Outdated
Show resolved
Hide resolved
|
@shakeeb-upstart would you be able to add a unit test for regression purposes? |
pjfanning
requested changes
Nov 20, 2024
| override def routes(mrps: ManagementRouteProviderSettings): Route = routes() | ||
|
|
||
| /** | ||
| * @since 1.1.0 |
There was a problem hiding this comment.
1.1.0 was already released so we need to decide whether this can go in 1.1.1 or if we need a 1.2.0 before this can be released
There was a problem hiding this comment.
not much point changing this yet - but I will block the merge until we can discuss how to eventually release this (which affects which branch we can use)
There was a problem hiding this comment.
yes sure, let me know if I am needed for any part in the discussion.
raboof
reviewed
Apr 25, 2025
| * @since 1.1.0 | ||
| */ | ||
| object HealthCheckRoutes extends ExtensionId[HealthCheckRoutes] with ExtensionIdProvider { | ||
| override def get(system: ActorSystem): HealthCheckRoutes = super.get(system) |
There was a problem hiding this comment.
returning it here means HealthCheckRoutes is becoming public API, so we should remove the 'internal' markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an extension provider for HealthCheckRoutes, so users can get the routes and add it to their own server