[WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial join library #310

pwrliang · 2025-11-15T00:14:44Z

This PR adds a GPU-accelerated spatial join library called libgpuspatial under c/sedona-libgpuspatial/libgpuspatial to support SedonaDB's GPU-acceleration feature. The GPU execution is automatically enabled when available and provides significant performance improvements for large-scale spatial joins. A Rust package called sedona-libgpuspatial for building and using the library is included under c/sedona-libgpuspatial. Currently, there's no GitHub action runner that has a GPU, so we only build the library and tests without actually running them.

jiayuasu · 2025-11-17T01:33:47Z

@pwrliang now the CI is working

paleolimbot

This is amazing! It has been very cool to watch this project evolve over the last six months and I know this represents a huge amount of work.

This is a large change and I wanted to leave a few high-level things to think about while you're polishing this up.

I see a bit of commented-out code in some of the files...feel free to file GitHub issues if that code represents a future piece of work that needs doing (and remove the commented-out code)!
I see CUDA-specific tests, which are great! If there are portions of the code that aren't well-covered by tests we do need to add them (we can open follow-on issues and do this in follow-up PRs too)
Because we're an Apache project we need the licensing and provenance of the files to be clear. I see some copyright notices from Nvidia...there's a place in LICENSE.md to acknowledge subdirectories where code was copied. We also need license headers on all the files (there's a script in scripts/ that can help do mass addition of the license header to a bunch of files at once).
It looks like you've done a great job ensuring the casual contributor doesn't have to deal with the GPU build complexity using default-members. That was one of my initial concerns but it looks great so far.

Give me a ping when you're ready for me to take a look!

pwrliang · 2025-11-20T02:19:32Z

This is amazing! It has been very cool to watch this project evolve over the last six months and I know this represents a huge amount of work.

This is a large change and I wanted to leave a few high-level things to think about while you're polishing this up.

I see a bit of commented-out code in some of the files...feel free to file GitHub issues if that code represents a future piece of work that needs doing (and remove the commented-out code)!

I see CUDA-specific tests, which are great! If there are portions of the code that aren't well-covered by tests we do need to add them (we can open follow-on issues and do this in follow-up PRs too)

Because we're an Apache project we need the licensing and provenance of the files to be clear. I see some copyright notices from Nvidia...there's a place in LICENSE.md to acknowledge subdirectories where code was copied. We also need license headers on all the files (there's a script in scripts/ that can help do mass addition of the license header to a bunch of files at once).

It looks like you've done a great job ensuring the casual contributor doesn't have to deal with the GPU build complexity using default-members. That was one of my initial concerns but it looks great so far.

Give me a ping when you're ready for me to take a look!

@paleolimbot Hi, Dewey, thanks for your attention. Currently, this PR has resolved the license issues, and can pass almost all of the jobs in the CI. I'd like to hear any suggestions from you. @zhangfengcdt has written the Rust part to hook up sedona-db to libgpuspatial, so the credits for building go to him.

zhangfengcdt · 2025-11-20T14:52:30Z

@pwrliang Thanks for opening this PR! As per our discussion, we could break down this large PR into smaller ones to make it manageable and reviewable. Ideally, (1)libgpuspatial (c++ and cuda) with tests (2) gpu spatial join module in rust (3) build pipelines and e2e tests.

Let me know if you can reduce this to only include (1) with the proper cleanup and apache license headers. We can continue (2) and (3) once this one merges. Thanks!

pwrliang · 2025-11-20T20:34:35Z

@pwrliang Thanks for opening this PR! As per our discussion, we could break down this large PR into smaller ones to make it manageable and reviewable. Ideally, (1)libgpuspatial (c++ and cuda) with tests (2) gpu spatial join module in rust (3) build pipelines and e2e tests.

Let me know if you can reduce this to only include (1) with the proper cleanup and apache license headers. We can continue (2) and (3) once this one merges. Thanks!

@zhangfengcdt Hi Feng, I have changed this PR to only keep the libgpuspatial part according to your suggestions. Please take a look.

zhangfengcdt · 2025-11-23T17:39:56Z

@pwrliang Thanks for opening this PR! As per our discussion, we could break down this large PR into smaller ones to make it manageable and reviewable. Ideally, (1)libgpuspatial (c++ and cuda) with tests (2) gpu spatial join module in rust (3) build pipelines and e2e tests.
Let me know if you can reduce this to only include (1) with the proper cleanup and apache license headers. We can continue (2) and (3) once this one merges. Thanks!

@zhangfengcdt Hi Feng, I have changed this PR to only keep the libgpuspatial part according to your suggestions. Please take a look.

@pwrliang Could you please take a look at the failing lints and tests in the ci? Thanks!

pwrliang · 2025-11-24T04:48:09Z

@pwrliang Thanks for opening this PR! As per our discussion, we could break down this large PR into smaller ones to make it manageable and reviewable. Ideally, (1)libgpuspatial (c++ and cuda) with tests (2) gpu spatial join module in rust (3) build pipelines and e2e tests.
Let me know if you can reduce this to only include (1) with the proper cleanup and apache license headers. We can continue (2) and (3) once this one merges. Thanks!

@zhangfengcdt Hi Feng, I have changed this PR to only keep the libgpuspatial part according to your suggestions. Please take a look.

@pwrliang Could you please take a look at the failing lints and tests in the ci? Thanks!

@zhangfengcdt I have fixed the CI. It failed because the runner did not have NVIDIA drivers, and the tests need to link libcuda.so, which comes from the drivers. After installing them, it succeeded.

zhangfengcdt

Thank you, @pwrliang ! It looks good to me now.

paleolimbot · 2025-11-25T01:32:43Z

Thanks Feng for taking a look!

I mentioned this to Feng offline, but we're preparing for the 0.2.0 release and I'd like to wait on merging this until we create the release branch. I'll also take a quick look for repo-level stuff before we merge.

paleolimbot

Apologies for the delay reviewing this!

Thank you for handling most of the licensing and commented out code issues! I still have a few questions about both (most of the below comments).

After this PR is merged I would like to further separate the C library build such that the mechanism for loading libgpuspatial is deferred to runtime (i.e., sd.load_extension("/path/to/installed/libgpuspatial.so"). This would mean that the Rust build and the C library build are completely separated (and would make it much easier to use this from Python). This is how DuckDB handles extensions and is how I'm planning to handle the s2geography dependency since that's causing some build problems for contributors.

c/sedona-libgpuspatial/libgpuspatial/include/gpuspatial/geom/geometry_collection.cuh

c/sedona-libgpuspatial/libgpuspatial/cmake/nvcuda_compile_module.cmake

paleolimbot · 2025-12-02T16:48:44Z

c/sedona-libgpuspatial/libgpuspatial/NOTICE

I believe our top level LICENSE has lines like this in it. Can these attributions be inlined into that file so they are all in one place?

I will merge the NOTICE file into LICENSE. However, I found a problem that there's no "licenses" folder at all

sedona-db/LICENSE

Line 205 in d53d6a1

This section summarizes those components and their licenses. See licenses/

That was copied over from apache/sedona and doesn't apply here...if we get complaints that the LICENSES file is unweildy or inappropriately formatted we can update its structure. Some Apache projects use licenses/, some use NOTICE.txt, or some inline everything into LICENSE. The important part is that vendored dependencies are acknowledged somewhere.

This file is also missing geoarrow-c-geos.

c/sedona-libgpuspatial/libgpuspatial/.pre-commit-config.yaml

c/sedona-libgpuspatial/CMakeLists.txt

c/sedona-libgpuspatial/libgpuspatial/test/related_test.cu

c/sedona-libgpuspatial/src/lib.rs

c/sedona-libgpuspatial/src/libgpuspatial.rs

Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>

…pache#363)

…che#375)

Co-authored-by: Peter Nguyen <petern0408@gmail.com>

… and not by index (apache#384)

…che#390)

Co-authored-by: Peter Nguyen <petern0408@gmail.com>

…lumns is less than the geometry column index (apache#385) Co-authored-by: Peter Nguyen <petern0408@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rquet 1.1 bounding box columns (apache#398)

…apache#400)

…#383)

Co-authored-by: Peter Nguyen <petern0408@gmail.com> Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>

apache#405)

Fix building issue Fix building issue fix test

pwrliang · 2025-12-06T14:32:30Z

Thank you @paleolimbot I have resolved most of the issues. Here's the list that remains unsolved.

License: We need a licenses folder to store all the original license files. LICENSE says there's one but it's not there

sedona-db/LICENSE

Line 205 in d53d6a1

This section summarizes those components and their licenses. See licenses/

Some commented test cases of RelateEngine cannot pass yet. I removed them and opened an issue
#415

The spatial join function in https://github.com/apache/sedona-db/pull/310/files/57d9c8b75e991f39332d71bbd034b94a74931ed3#diff-6eb1464960f8bc6d254ac43cb8509261f81845a5da98c29bd55a3278c7ac3fd9 does not have tests. I opened an issue for it #414

paleolimbot · 2025-12-08T03:36:52Z

Thank you for these updates! I'll take a look tomorrow morning. Looking forward to getting this merged!

paleolimbot

The CI failure is because my merge attempt on the lockfile wasn't quite right (sorry!):

error: the lock file /home/runner/work/sedona-db/sedona-db/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.

...any run of cargo should fix that.

License: We need a licenses folder to store all the original license files. LICENSE says there's one but it's not there

I left a note inline...for the purposes of this PR just put everything in LICENSE (and add geoarrow-c-geos).

I think that's it from my end!

paleolimbot · 2025-12-08T19:39:10Z

c/sedona-libgpuspatial/libgpuspatial/NOTICE

That was copied over from apache/sedona and doesn't apply here...if we get complaints that the LICENSES file is unweildy or inappropriately formatted we can update its structure. Some Apache projects use licenses/, some use NOTICE.txt, or some inline everything into LICENSE. The important part is that vendored dependencies are acknowledged somewhere.

This file is also missing geoarrow-c-geos.

c/sedona-libgpuspatial/libgpuspatial/include/gpuspatial/relate/im.cuh

paleolimbot · 2025-12-08T19:55:43Z

c/sedona-libgpuspatial/libgpuspatial/test/geoarrow_geos/geoarrow_geos.c

+
+#include <errno.h>


You've copied enough of it here that it needs to be acknowledged in LICENSE. I filed geoarrow/geoarrow-c-geos#6 so that hopefully we can avoid a vendor in the future.

pwrliang changed the title ~~feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial joins~~ [WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial joins Nov 15, 2025

paleolimbot reviewed Nov 18, 2025

View reviewed changes

Add libgpuspatial module

702f206

pwrliang force-pushed the gpu branch from b928ccf to 702f206 Compare November 20, 2025 15:56

pwrliang added 2 commits November 20, 2025 16:22

Fix CI

8412bec

Fix tests

dc18500

pwrliang changed the title ~~[WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial joins~~ [WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial join library Nov 20, 2025

pwrliang added 3 commits November 23, 2025 21:38

Fix building of tests

2705e68

Fix CI

7130ccf

Fix CI

57d9c8b

zhangfengcdt approved these changes Nov 24, 2025

View reviewed changes

paleolimbot reviewed Dec 2, 2025

View reviewed changes

paleolimbot mentioned this pull request Dec 3, 2025

feat(c/sedona-extension): Move FFI scalar kernel definitions to c/sedona-extension and write them in C #407

Open

This was referenced Dec 5, 2025

Need to add unit tests to the GPU-based spatial join #414

Open

Need a more robust polygon-polygon related function in the GPU-based spatial join #415

Open

pwrliang and others added 8 commits December 5, 2025 01:18

Resolve some issues

cf5bf6d

Fix build.rs

8a178f9

Merge branch 'main' of https://github.com/apache/sedona-db into gpu

0137a86

Fix an error

c201681

Fix building issue

56e6137

Fix building issue

4dac890

feat(rust/sedona-functions): Implement ST_GeometryN (apache#317)

fbfe907

feat(c/sedona-geos): Implement ST_MinimumClearance (apache#314)

4bc1703

Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>

Abeeujah and others added 20 commits December 5, 2025 22:04

feat(rust/sedona-functions): Implement ST_Reverse using geo-traits (a…

a3243d2

…pache#363)

chore(rust,c): Run cargo clippy --fix (apache#373)

3ed834a

chore(dev/release): Ensure release verification passes for 0.2.0 (apa…

5f1c4ed

…che#375)

chore(docs): Update mkdocs for latest mkdocstrings (apache#382)

f3409c6

feat(c/sedona-geos): Add ST_NumInteriorRings (apache#369)

7238f43

Co-authored-by: Peter Nguyen <petern0408@gmail.com>

fix(rust/sedona-expr): Resolve filter expression bounding box by name…

51a37bd

… and not by index (apache#384)

docs(r/sedonadb): Minor fix to remove an unintentional cross-ref (apa…

42cb353

…che#390)

feat(c/sedona-geos): Implement ST_NumPoints (apache#386)

99ffe74

Co-authored-by: Peter Nguyen <petern0408@gmail.com>

fix(rust/sedona-expr): Fix GeoParquet pruning when number of final co…

7fa582a

…lumns is less than the geometry column index (apache#385) Co-authored-by: Peter Nguyen <petern0408@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(rust/sedona-geoparquet): Don't use ProjectionExec to create GeoPa…

3303384

…rquet 1.1 bounding box columns (apache#398)

docs(examples): Add note about the SRID arg of ST_Point() (apache#392)

f75a5b2

feat(rust/sedona-functions): Implement ST_InteriorRingN (apache#381)

822fdc0

chore(r/sedonadb): Update savvy to v0.9 (apache#401)

ada31ee

chore(dependabot): Add groups for datafusion, wasm-bindgen, and savvy (…

9a553eb

…apache#400)

feat(c/sedona-geos): Implement ST_NRings (apache#387)

1068d49

chore(ci): pre-commit add 6 more hooks and clean up (apache#378)

38c6df8

feat(rust/sedona-raster-functions): Add RS_RasterToWorldCoord (apache…

b59da6b

…#383)

docs: Update SQL docs for changes in v0.2 (apache#368)

0991832

Co-authored-by: Peter Nguyen <petern0408@gmail.com> Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>

feat(rust/sedona-raster-functions): Add RS_RasterToWorldCoord as Point (

8c3d5be

apache#405)

Fix an error

24f1b00

Fix building issue Fix building issue fix test

pwrliang force-pushed the gpu branch from 4dac890 to 24f1b00 Compare December 6, 2025 03:05

pwrliang and others added 3 commits December 5, 2025 22:07

Merge branch 'main' of https://github.com/apache/sedona-db into gpu

48c8d7b

Merge branch 'gpu' of github.com:pwrliang/sedona-db into gpu

2d14e41

Fix format issue

cb38525

Merge branch 'main' into gpu

0e39cb7

paleolimbot reviewed Dec 8, 2025

View reviewed changes

pwrliang and others added 2 commits December 8, 2025 20:32

Rewrite intersection matrix

68f0d04

Update Cargo.lock and fix license issues

20a257b


		#include <errno.h>

[WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial join library #310

Are you sure you want to change the base?

[WIP] feat(c/sedona-libgpuspatial) Add GPU-accelerated spatial join library #310

Conversation

pwrliang commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiayuasu commented Nov 17, 2025

Uh oh!

paleolimbot left a comment

Choose a reason for hiding this comment

Uh oh!

pwrliang commented Nov 20, 2025

Uh oh!

zhangfengcdt commented Nov 20, 2025

Uh oh!

pwrliang commented Nov 20, 2025

Uh oh!

zhangfengcdt commented Nov 23, 2025

Uh oh!

pwrliang commented Nov 24, 2025

Uh oh!

zhangfengcdt left a comment

Choose a reason for hiding this comment

Uh oh!

paleolimbot commented Nov 25, 2025

Uh oh!

paleolimbot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

paleolimbot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

pwrliang Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

paleolimbot Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pwrliang commented Dec 6, 2025

Uh oh!

paleolimbot commented Dec 8, 2025

Uh oh!

paleolimbot left a comment

Choose a reason for hiding this comment

Uh oh!

paleolimbot Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paleolimbot Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

pwrliang commented Nov 15, 2025 •

edited

Loading