diff --git a/lib/appsignal/check_in/scheduler.ex b/lib/appsignal/check_in/scheduler.ex index fe8d5db5a..ae2b4245c 100644 --- a/lib/appsignal/check_in/scheduler.ex +++ b/lib/appsignal/check_in/scheduler.ex @@ -120,7 +120,7 @@ defmodule Appsignal.CheckIn.Scheduler do end @impl true - def terminate(_reason, %{events: events}) when length(events) > 0 do + def terminate(_reason, %{events: [_ | _] = events}) do # If any events are stored, attempt to transmit them before the # process is terminated. handle_continue({:transmit, events}, initial_state()) diff --git a/test/appsignal/error_test.exs b/test/appsignal/error_test.exs index b1c505578..8a4e3b59b 100644 --- a/test/appsignal/error_test.exs +++ b/test/appsignal/error_test.exs @@ -21,7 +21,7 @@ defmodule Appsignal.ErrorTest do test "format's the error's stack trace", %{metadata: metadata} do {_name, _message, stack} = metadata assert is_list(stack) - assert length(stack) > 0 + refute Enum.empty?(stack) assert Enum.all?(stack, &is_binary(&1)) end end @@ -46,7 +46,7 @@ defmodule Appsignal.ErrorTest do test "format's the error's stack trace", %{metadata: metadata} do {_name, _message, stack} = metadata assert is_list(stack) - assert length(stack) > 0 + refute Enum.empty?(stack) assert Enum.all?(stack, &is_binary(&1)) end end @@ -73,7 +73,7 @@ defmodule Appsignal.ErrorTest do test "format's the error's stack trace", %{metadata: metadata} do {_name, _message, stack} = metadata assert is_list(stack) - assert length(stack) > 0 + refute Enum.empty?(stack) assert Enum.all?(stack, &is_binary(&1)) end end @@ -101,7 +101,7 @@ defmodule Appsignal.ErrorTest do test "format's the error's stack trace", %{metadata: metadata} do {_name, _message, stack} = metadata assert is_list(stack) - assert length(stack) > 0 + refute Enum.empty?(stack) assert Enum.all?(stack, &is_binary(&1)) end end @@ -126,7 +126,7 @@ defmodule Appsignal.ErrorTest do test "format's the error's stack trace", %{metadata: metadata} do {_name, _message, stack} = metadata assert is_list(stack) - assert length(stack) > 0 + refute Enum.empty?(stack) assert Enum.all?(stack, &is_binary(&1)) end end diff --git a/test/appsignal/stacktrace_test.exs b/test/appsignal/stacktrace_test.exs index 7fa9507a9..a85286743 100644 --- a/test/appsignal/stacktrace_test.exs +++ b/test/appsignal/stacktrace_test.exs @@ -14,7 +14,7 @@ defmodule Appsignal.StacktraceTest do end test "does not return an empty list", %{stack: stack} do - assert length(stack) > 0 + refute Enum.empty?(stack) end test "returns a stacktrace containing the error", %{