Refactor

Author: mirkokurt

src/arduino/app_utils/leds.py

@@ -18,18 +18,6 @@
 ]
 
 
-def set_led1_color(r, g, b):
-    write_led_file(LED_BRIGHTNESS_FILES[0], r)
-    write_led_file(LED_BRIGHTNESS_FILES[1], g)
-    write_led_file(LED_BRIGHTNESS_FILES[2], b)
-
-
-def set_led2_color(r, g, b):
-    write_led_file(LED_BRIGHTNESS_FILES[3], r)
-    write_led_file(LED_BRIGHTNESS_FILES[4], g)
-    write_led_file(LED_BRIGHTNESS_FILES[5], b)
-
-
 def write_led_file(led_file, color):
     try:
         with open(led_file, "w") as f:
@@ -40,6 +28,7 @@ def write_led_file(led_file, color):
 
 class Leds:
     @staticmethod
+    # Led 1 and 2 are controlled by directly (MPU), while Led 3 and 4 are controlled via Bridge (MCU)
     def set_led_color(ledid: int, rgb_color: dict):
         try:
             if ledid not in LED_IDS:
@@ -48,17 +37,33 @@ def set_led_color(ledid: int, rgb_color: dict):
             if not rgb_color or not all(k in rgb_color for k in ("r", "g", "b")):
                 raise ValueError("Color must be an object with 'r', 'g', 'b' keys")
 
-            # Led 1 and 2 are controlled by Python code directly (MPU), while Led 3 and 4 are controlled via Bridge (MCU)
             match ledid:
                 case 1:
-                    set_led1_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
+                    Leds.set_led1_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
                 case 2:
-                    set_led2_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
-                case 3 | 4:
-                    Bridge.call("set_led_color", ledid, rgb_color["r"], rgb_color["g"], rgb_color["b"])
+                    Leds.set_led2_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
+                case 3:
+                    Leds.set_led3_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
+                case 4:
+                    Leds.set_led4_color(rgb_color["r"], rgb_color["g"], rgb_color["b"])
 
         except Exception as e:
             Logger(__name__).error(f"LED color set error: {e}")
 
+    @staticmethod
+    def set_led1_color(r, g, b):
+        write_led_file(LED_BRIGHTNESS_FILES[0], r)
+        write_led_file(LED_BRIGHTNESS_FILES[1], g)
+        write_led_file(LED_BRIGHTNESS_FILES[2], b)
+
+    @staticmethod
+    def set_led2_color(r, g, b):
+        write_led_file(LED_BRIGHTNESS_FILES[3], r)
+        write_led_file(LED_BRIGHTNESS_FILES[4], g)
+        write_led_file(LED_BRIGHTNESS_FILES[5], b)
+
+    def set_led3_color(r, g, b):
+        Bridge.call("set_led_color", 3, r, g, b)
 
-Leds = Leds()
+    def set_led4_color(r, g, b):
+        Bridge.call("set_led_color", 4, r, g, b)