Adds a match method for eager loading
#1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found this class useful in my own projects. By adding the `match` method you will now get only a single result, not a collection with a single result when eager or lazy loading your relationship when you call `expectOne`.
use Collection
|
This is not quite done yet. I'll reopen when its fixed. |
Should now return only a single instance when eager/lazy loading, not an array
|
Thanks for the contribution! (First PR for AIC's data hub 🎉) We are currently all-hands-on-deck on another project, but we should have a chance to revisit the more architectural aspects of this one in November. We'll look into merging this then! |
IllyaMoskvin
force-pushed
the
develop
branch
3 times, most recently
from
a13a5c2 to
d5e4ba1
Compare
IllyaMoskvin
force-pushed
the
develop
branch
3 times, most recently
from
a1b5ef0 to
1a7ac33
Compare
IllyaMoskvin
force-pushed
the
develop
branch
from
ca06577 to
f814737
Compare
nikhiltri
force-pushed
the
develop
branch
2 times, most recently
from
050f8dd to
9d880e6
Compare
nikhiltri
force-pushed
the
develop
branch
6 times, most recently
from
3d1fddd to
99bb08e
Compare
nikhiltri
force-pushed
the
develop
branch
5 times, most recently
from
f6a921e to
45dded7
Compare
nikhiltri
force-pushed
the
develop
branch
4 times, most recently
from
beeaca9 to
d87c4c8
Compare
nikhiltri
force-pushed
the
develop
branch
3 times, most recently
from
d94883e to
0fb57a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this class useful in my own projects. By adding the
matchmethod you will now get only a single result, not a collection with a single result when eager or lazy loading your relationship when you callexpectOne.