feat: ✨ Add builtin SSL support

Author: arthurlm

.config/nextest.toml

@@ -4,3 +4,7 @@ serial-integration = { max-threads = 1 }
 [[profile.default.overrides]]
 filter = 'package(quickfix) + test(test_log_factory)'
 test-group = 'serial-integration'
+
+[[profile.default.overrides]]
+filter = 'package(quickfix) + test(test_send_receive)'
+test-group = 'serial-integration'

.github/actions/builder/action.yaml

@@ -14,4 +14,4 @@ runs:
     - uses: cargo-bins/cargo-binstall@main
     - name: Install nextest
       shell: bash
-      run: cargo binstall cargo-nextest --secure
+      run: cargo binstall cargo-nextest --secure --force

.github/workflows/ci.yml

@@ -32,6 +32,21 @@ jobs:
       - name: Run tests
         run: cargo nextest run
 
+  test_ssl:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: true
+      - uses: ./.github/actions/builder
+      - uses: ./.github/actions/rustcSetup
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install --yes libssl-dev
+      - name: Run tests
+        run: cargo nextest run -F build-with-ssl
+
   test_mysql:
     runs-on: ubuntu-latest
     steps:

.github/workflows/coverage.yml

@@ -23,13 +23,17 @@ jobs:
         with:
           components: llvm-tools-preview
 
-      - name: Install cargo-llvm-cov
-        uses: taiki-e/install-action@v2.18.9
-        with:
-          tool: cargo-llvm-cov
+      - uses: taiki-e/install-action@cargo-llvm-cov
+      - uses: taiki-e/install-action@nextest
 
       - name: Generate code coverage
-        run: cargo llvm-cov --workspace --exclude quickfix-ffi --ignore-filename-regex quickfix-ffi --all-features --codecov --output-path codecov.json
+        run: |
+          cargo llvm-cov nextest \
+            --workspace \
+            --exclude quickfix-ffi \
+            --ignore-filename-regex quickfix-ffi \
+            --all-features \
+            --codecov --output-path codecov.json
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3.1.4

.gitmodules

@@ -1,4 +1,4 @@
 [submodule "quickfix-ffi/libquickfix"]
 	path = quickfix-ffi/libquickfix
-	url = https://github.com/quickfix/quickfix.git
-	branch = master
+	url = https://github.com/zqw86713/quickfix.git
+	branch = qinweiz

doc/ABOUT.md

@@ -18,45 +18,41 @@ What is already bind and working in this crate:
 
 What I do **not** plan to bind from this crate:
 
-1. SSL support.
+1. Python / Ruby binding.
 
-    Use binary like `stunnel` to emulate the feature.
-    It is simpler to use than the original SSL quickfix, even if it add some performances overhead.
+   Use original library instead obviously.
 
-2. Python / Ruby binding.
+2. Autotools build toolchain.
 
-    Use original library instead obviously.
+   Just use `cmake` once and for all !
+   We are in 2023+ and not targeting OS from the 80s.
 
-3. Autotools build toolchain.
+3. FIX 5x messages generated code.
 
-    Just use `cmake` once and for all !
-    We are in 2023+ and not targeting OS from the 80s.
+   FIX 5x XML definition is a little bit weird ...
+   For example:
 
-4. FIX 5x messages generated code.
+   - In [MatchType](https://www.onixs.biz/fix-dictionary/5.0/tagNum_574.html) some tag is defined multiple times.
+     Generated enum are so inconsistent and cannot be safely generated.
+   - There are probably other incompatibility but I stopped here ...
 
-    FIX 5x XML definition is a little bit weird ...
-    For example:
-    - In [MatchType](https://www.onixs.biz/fix-dictionary/5.0/tagNum_574.html) some tag is defined multiple times.
-      Generated enum are so inconsistent and cannot be safely generated.
-    - There are probably other incompatibility but I stopped here ...
+   You can edit XML spec to your need and create a package with desired spec locally.\
+   Check FAQ for more info on this.
 
-    You can edit XML spec to your need and create a package with desired spec locally.\
-    Check FAQ for more info on this.
+4. All binding of `LogFactory`.
 
-5. All binding of `LogFactory`.
+   I just provide Rust standard trait.
+   You can implement whatever you want using standard Rust crate and impl 3 callbacks (logger / redis / syslog / sql / ...).
 
-    I just provide Rust standard trait.
-    You can implement whatever you want using standard Rust crate and impl 3 callbacks (logger / redis / syslog / sql / ...).
+   Moreover Rust file descriptor are protected by mutex, so this avoid mixing log from C++ / Rust in the same program.
 
-    Moreover Rust file descriptor are protected by mutex, so this avoid mixing log from C++ / Rust in the same program.
-
-6. Custom `MessageStoreFactory` from rust.
+5. Custom `MessageStoreFactory` from rust.
 
    For now, only `FileMessageStoreFactory` and `MemoryMessageStoreFactory` are bind.
    You can use also use `MySqlMessageStoreFactory` and `PostgresMessageStoreFactory` when enabling crate feature flag.
    Implementing message store from rust side is a little bit tricky and I am not 100% sure of the correct way to proceed.
 
-7. Exotic operating system.
+6. Exotic operating system.
 
-    AIX / Solaris are not targeted.
-    They are not Rust [Tier1](https://doc.rust-lang.org/nightly/rustc/platform-support.html) for now.
+   AIX / Solaris are not targeted.
+   They are not Rust [Tier1](https://doc.rust-lang.org/nightly/rustc/platform-support.html) for now.

examples/README.md

@@ -8,18 +8,16 @@ Because it is the simplest one to setup and it has a sandbox to play with.
 
 ## Getting started
 
-1. Install [`stunnel`](https://www.stunnel.org/).
-2. Run it with `stunnel ./examples/stunnel.conf`.
-3. Create a API token to [Coinbase sandbox API](https://public.sandbox.exchange.coinbase.com/profile/api) with:
+1. Create a API token to [Coinbase sandbox API](https://public.sandbox.exchange.coinbase.com/profile/api) with:
    - Trade permission
    - Your IP
-4. Setup following env variables:
+2. Setup following env variables:
    - `COINBASE_API_KEY`
    - `COINBASE_API_PASSPHRASE`
    - `COINBASE_API_SECRET`
-5. Check the code and update to your need.
-6. Add some fund to your [sandbox portfolio](https://public.sandbox.exchange.coinbase.com/portfolios).
-7. Launch the `coinbase-example` app 🚀 !!!
+3. Check the code and update to your need.
+4. Add some fund to your [sandbox portfolio](https://public.sandbox.exchange.coinbase.com/portfolios).
+5. Launch the `coinbase-example` app 🚀 !!!
 
 ## Including code from github instead of crates.io
 

examples/coinbase-example/src/lib.rs

@@ -18,8 +18,8 @@ pub fn build_session_settings(config: &CoinbaseConfig) -> anyhow::Result<Session
             &StartTime("00:00:01"),
             &EndTime("23:59:59"),
             &HeartBtInt(30),
-            &SocketConnectPort(5298), // ⚠️ This port should match what you have in your stunnel configuration file.
-            &SocketConnectHost("127.0.0.1"),
+            &SocketConnectPort(4198),
+            &SocketConnectHost("fix-public.sandbox.exchange.coinbase.com"),
             &DataDictionary("data/order-entry/FIX42-prod-sand.xml"),
         ])?,
     )?;
@@ -30,8 +30,8 @@ pub fn build_session_settings(config: &CoinbaseConfig) -> anyhow::Result<Session
             &StartTime("00:00:01"),
             &EndTime("23:59:59"),
             &HeartBtInt(30),
-            &SocketConnectPort(7221), // ⚠️ This port should match what you have in your stunnel configuration file.
-            &SocketConnectHost("127.0.0.1"),
+            &SocketConnectPort(6121),
+            &SocketConnectHost("fix-md.sandbox.exchange.coinbase.com"),
             &DataDictionary("data/order-entry/FIX42-prod-sand.xml"),
             &DefaultApplVerID("9" /* FIX 5.0 SP2 */),
             &DataDictionary("data/market-data/FIX50-prod-sand.xml"),

examples/stunnel.conf

@@ -5,11 +5,18 @@ set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/libquickfix/cmake/")
 
+option(HAVE_SSL "Build with SSL" OFF)
 option(HAVE_MYSQL "Build with MySQL" OFF)
 option(HAVE_POSTGRESQL "Build with PostgreSQL" OFF)
 
 option(QUICKFIX_BIND_EXAMPLES "Build quickfix C binding examples" ON)
 
+if (HAVE_SSL)
+    find_package(OpenSSL REQUIRED)
+    include_directories(${OPENSSL_INCLUDE_DIR})
+    message("-- Building with OpenSSL")
+endif()
+
 if (HAVE_MYSQL)
     find_package(MySQL REQUIRED)
     include_directories(${MYSQL_INCLUDE_DIR})