Merge pull request #3 from zarathustra323/slinsights

Minor bug fixes/cleanup and initial testing

Author: Jacob Bare

.gitignore

@@ -46,4 +46,4 @@
 
 # Backup entities generated with doctrine:generate:entities command
 */Entity/*~
-.DS_Store
+/composer.lock

.travis.yml

@@ -0,0 +1,6 @@
+language: php
+php:
+  - '5.4'
+  - '5.6'
+install:
+  - composer install --no-interaction

DependencyInjection/As3PostProcessExtension.php

@@ -6,8 +6,6 @@
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Symfony\Component\DependencyInjection\Loader;
-use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\Reference;
 
 /**
  * This is the class that loads and manages your bundle configuration
@@ -22,7 +20,7 @@ class As3PostProcessExtension extends Extension
     public function load(array $configs, ContainerBuilder $container)
     {
         $configuration = new Configuration();
-        $config = $this->processConfiguration($configuration, $configs);
+        $this->processConfiguration($configuration, $configs);
 
         // Load bundle services
         $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

DependencyInjection/Configuration.php

@@ -18,7 +18,7 @@ class Configuration implements ConfigurationInterface
     public function getConfigTreeBuilder()
     {
         $treeBuilder = new TreeBuilder();
-        $rootNode = $treeBuilder->root('as3_post_process');
+        $treeBuilder->root('as3_post_process');
         return $treeBuilder;
     }
 }

Task/TaskManager.php

@@ -63,7 +63,7 @@ public function addTask(TaskInterface $task, $priority = 0)
             'object'    => $task,
             'priority'  => (Integer) $priority,
         ];
-        $this->tasks[get_class($task)] = $prioritized;
+        $this->tasks[] = $prioritized;
 
         $sortFunc = function ($a, $b) {
             return $a['priority'] > $b['priority'] ? -1 : 1;

Tests/TaskManagerTest.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace As3\Bundle\PostProcessBundle\Tests;
+
+use As3\Bundle\PostProcessBundle\Task\TaskManager;
+
+class TaskManagerTest extends \PHPUnit_Framework_TestCase
+{
+    private $manager;
+
+    protected function setUp()
+    {
+        $this->manager = new TaskManager();
+    }
+
+    public function testTaskPriority()
+    {
+        $task1 = new TestTask('1');
+        $task2 = new TestTask('2');
+        $task3 = new TestTask('3');
+
+        $this->manager->addTask($task1);
+        $this->manager->addTask($task2, 5);
+        $this->manager->addTask($task3, 1);
+
+        $tasks = $this->manager->getTasks();
+        $this->assertEquals(3, count($tasks));
+        $this->assertEquals('2', $tasks[0]->getKey(), 'Task priority order is incorrect.');
+        $this->assertEquals('3', $tasks[1]->getKey(), 'Task priority order is incorrect.');
+    }
+}

Tests/TestTask.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace As3\Bundle\PostProcessBundle\Tests;
+
+use As3\Bundle\PostProcessBundle\Task\TaskInterface;
+
+class TestTask implements TaskInterface
+{
+    private $key;
+
+    public function __construct($key)
+    {
+        $this->key = $key;
+    }
+
+    public function getKey()
+    {
+        return $this->key;
+    }
+
+    public function run()
+    {
+    }
+}

composer.json

@@ -2,7 +2,6 @@
     "name": "as3/post-process-bundle",
     "type": "symfony-bundle",
     "license": "MIT",
-    "type": "library",
     "description": "Provides centralized support for executing callable code before Symfony framework termination.",
     "authors": [
         {