Skip to content
This repository was archived by the owner on Dec 16, 2023. It is now read-only.
This repository was archived by the owner on Dec 16, 2023. It is now read-only.

ProxyRequest URL encodes URLs giving different behaviour to default node behaviour #133

@TTransmit

Description

@TTransmit

We have hit a minor gotcha when using node-replay.

The following line URL encodes the URL and request parameters when using record mode in replay: https://github.com/assaf/node-replay/blob/master/src/proxy.js#L44

When running requests through replay, replay will correctly escape a request like https://www.example.com/test?query={"title":"Node replay is great"} to https://www.example.com/test?query=%7B%22title%22%3A%22Node%20replay%20is%20great%22%7D. The node app running locally doesn't encode the URLs. This gave a difference between behaviour during test driven development with replay and behaviour of the node app itself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions