Allows special char in S3 Bucket and Key (#616)

* Allows special char in S3 Bucket and Key

* Add tests

* Fix CS

Author: jderusse

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## NOT RELEASED
+
+### Fixed
+
+- Fixed issue when Layer, Function or Version contained a special char `#`
+
 ## 0.4.2
 
 ### Fixed

src/Input/AddLayerVersionPermissionRequest.php

@@ -157,7 +157,7 @@ public function request(): Request
             throw new InvalidArgument(sprintf('Missing parameter "VersionNumber" for "%s". The value cannot be null.', __CLASS__));
         }
         $uri['VersionNumber'] = $v;
-        $uriString = "/2018-10-31/layers/{$uri['LayerName']}/versions/{$uri['VersionNumber']}/policy";
+        $uriString = '/2018-10-31/layers/' . rawurlencode($uri['LayerName']) . '/versions/' . rawurlencode($uri['VersionNumber']) . '/policy';
 
         // Prepare Body
         $bodyPayload = $this->requestBody();

src/Input/InvocationRequest.php

@@ -153,7 +153,7 @@ public function request(): Request
             throw new InvalidArgument(sprintf('Missing parameter "FunctionName" for "%s". The value cannot be null.', __CLASS__));
         }
         $uri['FunctionName'] = $v;
-        $uriString = "/2015-03-31/functions/{$uri['FunctionName']}/invocations";
+        $uriString = '/2015-03-31/functions/' . rawurlencode($uri['FunctionName']) . '/invocations';
 
         // Prepare Body
         $body = $this->Payload ?? '';

src/Input/ListLayerVersionsRequest.php

@@ -115,7 +115,7 @@ public function request(): Request
             throw new InvalidArgument(sprintf('Missing parameter "LayerName" for "%s". The value cannot be null.', __CLASS__));
         }
         $uri['LayerName'] = $v;
-        $uriString = "/2018-10-31/layers/{$uri['LayerName']}/versions";
+        $uriString = '/2018-10-31/layers/' . rawurlencode($uri['LayerName']) . '/versions';
 
         // Prepare Body
         $body = '';

src/Input/PublishLayerVersionRequest.php

@@ -122,7 +122,7 @@ public function request(): Request
             throw new InvalidArgument(sprintf('Missing parameter "LayerName" for "%s". The value cannot be null.', __CLASS__));
         }
         $uri['LayerName'] = $v;
-        $uriString = "/2018-10-31/layers/{$uri['LayerName']}/versions";
+        $uriString = '/2018-10-31/layers/' . rawurlencode($uri['LayerName']) . '/versions';
 
         // Prepare Body
         $bodyPayload = $this->requestBody();