Merge pull request #19 from atcoder/patch/issue3

fix #3: fix internal_math for msvc

Author: yosupo06

atcoder/internal_math.hpp

@@ -83,7 +83,8 @@ constexpr bool is_prime_constexpr(int n) {
     if (n % 2 == 0) return false;
     long long d = n - 1;
     while (d % 2 == 0) d /= 2;
-    for (long long a : {2, 7, 61}) {
+    constexpr long long bases[3] = {2, 7, 61};
+    for (long long a : bases) {
         long long t = d;
         long long y = pow_mod_constexpr(a, t, n);
         while (t != n - 1 && y != 1 && y != n - 1) {

test/unittest/CMakeLists.txt

@@ -15,7 +15,7 @@ if(NOT MSVC)
     add_link_options(-fsanitize=undefined,address)
 else()
     message("Use MSVC")
-    add_compile_options(/W4)
+    add_compile_options(/W4 /permissive- /sdl)
 endif()
 
 add_subdirectory(googletest)

test/unittest/convolution_test.cpp

@@ -335,7 +335,7 @@ TEST(ConvolutionTest, ConvLLBound) {
     static constexpr unsigned long long M1M3 = MOD1 * MOD3;
     static constexpr unsigned long long M1M2 = MOD1 * MOD2;
     for (int i = -1000; i <= 1000; i++) {
-        std::vector<ll> a = {(long long)(-M1M2 - M1M3 - M2M3 + i)};
+        std::vector<ll> a = {(long long)(0ULL - M1M2 - M1M3 - M2M3 + i)};
         std::vector<ll> b = {1};
 
         ASSERT_EQ(a, convolution_ll(a, b));