Skip to content

Commit b9140ce

Browse files
simonrupfgonchik
authored andcommitted
fixing Confluence.remove_page_attachment_keep_version() function to not delete the whole attachment (#367)
1 parent bc1cb99 commit b9140ce

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

atlassian/confluence.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ def remove_page_attachment_keep_version(self, page_id, filename, keep_last_versi
520520
attachment_versions = self.get_attachment_history(attachment.get("id"))
521521
while len(attachment_versions) > keep_last_versions:
522522
remove_version_attachment_number = attachment_versions[keep_last_versions].get('number')
523-
self.delete_attachment(page_id=page_id, filename=filename, version=remove_version_attachment_number)
523+
self.delete_attachment_by_id(attachment_id=attachment.get("id"), version=remove_version_attachment_number)
524524
log.info(
525525
"Removed oldest version for {}, now versions equal more than {}".format(attachment.get('title'),
526526
len(attachment_versions)))

0 commit comments

Comments
 (0)