Skip to content

Security update #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tdugue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security update #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,16 @@ Add the following JSON config snippet into your desired config, eg. `config/loca
```json
"googleRecaptcha" : {
"tokens" : {
"site_key": "<YOUR_CAPTCHA_SITE_KEY>",
"secret_key": "<YOUR_CAPTCHA_SECRET_KEY>"
"site_key": "<YOUR_CAPTCHA_SITE_KEY>"
},
"endpoint": "/api/ext/google-recaptcha/is-verify",
"is_active": false
}
```
Replace the `site_key` & `secret_key` parameter with the site key & secret key provided by Google reCAPTCHA registration time. You can find your Captcha Site Key here: https://www.google.com/recaptcha/admin/. Setting `is_active` to `false` will disable the google reCAPTCHA extension at runtime.
Replace the `site_key` parameter with the site key & secret key provided by Google reCAPTCHA registration time. You can find your Captcha Site Key here: https://www.google.com/recaptcha/admin/. Setting `is_active` to `false` will disable the google reCAPTCHA extension at runtime.

Valid site_key example: `"site_key": "6Lcn_Z0UAAAAAN4LdRSfM5eNd3LJ-xPfUtnV6Lud"`
Valid secret_key example: `"secret_key": "6Lcn_Z0UAAAAACodWP8oU9wcdVKatvQVBqklWA9c"`

### 3. Register the Google reCAPTCHA extension
Open up your `../vue-storefront/src/modules/index.ts` and add the following code. Adding it inside this file the registers the extension so it can be used in your Vue Storefront.
```js
Expand Down
4 changes: 2 additions & 2 deletions hooks/afterRegistration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ export function afterRegistration({ Vue, config, store, isServer }): any {
Logger.warn('Google captcha module is disabled.', 'Google Recaptcha')();
return;
}
if( !config.googleRecaptcha.tokens || !config.googleRecaptcha.tokens.site_key || !config.googleRecaptcha.tokens.secret_key ) {
Logger.warn('No google captcha config or captcha site_key or captcha secret_key found.', 'Google Recaptcha')();
if( !config.googleRecaptcha.tokens || !config.googleRecaptcha.tokens.site_key ) {
Logger.warn('No google captcha config or captcha site_key found.', 'Google Recaptcha')();
return;
}
}
Expand Down