test: add tests for continue_request and fulfill_request methods

Author: thalissonvs

tests/test_browser/test_browser_base.py

@@ -18,7 +18,7 @@
 )
 from pydoll.protocol.fetch.events import FetchEvent
 from pydoll.connection.connection_handler import ConnectionHandler
-from pydoll.constants import DownloadBehavior, PermissionType, NetworkErrorReason
+from pydoll.constants import DownloadBehavior, PermissionType, NetworkErrorReason, RequestMethod
 
 
 class ConcreteBrowser(Browser):
@@ -612,7 +612,57 @@ async def test_disable_runtime_events(mock_browser):
     )
 
 
-# Tests for fail_request and fulfill_request
+# Tests for continue_request, fail_request and fulfill_request
+@pytest.mark.asyncio
+async def test_continue_request(mock_browser):
+    """Test continue_request with minimal parameters."""
+    request_id = 'test_request_123'
+    
+    await mock_browser.continue_request(request_id)
+    
+    mock_browser._connection_handler.execute_command.assert_called_with(
+        FetchCommands.continue_request(
+            request_id=request_id,
+            url=None,
+            method=None,
+            post_data=None,
+            headers=None,
+            intercept_response=None,
+        ), timeout=10
+    )
+
+
+@pytest.mark.asyncio
+async def test_continue_request_with_all_params(mock_browser):
+    """Test continue_request with all parameters."""
+    request_id = 'test_request_123'
+    url = 'https://modified-example.com'
+    method = RequestMethod.POST
+    post_data = 'modified_data=test'
+    headers = [{'name': 'Authorization', 'value': 'Bearer token123'}]
+    intercept_response = True
+    
+    await mock_browser.continue_request(
+        request_id=request_id,
+        url=url,
+        method=method,
+        post_data=post_data,
+        headers=headers,
+        intercept_response=intercept_response,
+    )
+    
+    mock_browser._connection_handler.execute_command.assert_called_with(
+        FetchCommands.continue_request(
+            request_id=request_id,
+            url=url,
+            method=method,
+            post_data=post_data,
+            headers=headers,
+            intercept_response=intercept_response,
+        ), timeout=10
+    )
+
+
 @pytest.mark.asyncio
 async def test_fail_request(mock_browser):
     """Test fail_request."""
@@ -628,19 +678,47 @@ async def test_fail_request(mock_browser):
 
 @pytest.mark.asyncio
 async def test_fulfill_request(mock_browser):
-    """Test fulfill_request."""
+    """Test fulfill_request with minimal parameters."""
+    request_id = 'test_request_123'
+    response_code = 200
+    
+    await mock_browser.fulfill_request(request_id, response_code)
+    
+    mock_browser._connection_handler.execute_command.assert_called_with(
+        FetchCommands.fulfill_request(
+            request_id=request_id,
+            response_code=response_code,
+            response_headers=None,
+            body=None,
+            response_phrase=None,
+        ), timeout=10
+    )
+
+
+@pytest.mark.asyncio
+async def test_fulfill_request_with_all_params(mock_browser):
+    """Test fulfill_request with all parameters."""
     request_id = 'test_request_123'
     response_code = 200
     response_headers = [{'name': 'Content-Type', 'value': 'application/json'}]
-    response_body = {'status': 'success', 'data': 'test'}
+    body = '{"status": "success", "data": "test"}'
+    response_phrase = 'OK'
 
     await mock_browser.fulfill_request(
-        request_id, response_code, response_headers, response_body
+        request_id=request_id,
+        response_code=response_code,
+        response_headers=response_headers,
+        body=body,
+        response_phrase=response_phrase,
     )
 
     mock_browser._connection_handler.execute_command.assert_called_with(
         FetchCommands.fulfill_request(
-            request_id, response_code, response_headers, response_body
+            request_id=request_id,
+            response_code=response_code,
+            response_headers=response_headers,
+            body=body,
+            response_phrase=response_phrase,
         ), timeout=10
     )
 

tests/test_browser/test_browser_tab.py

@@ -4,7 +4,7 @@
 from unittest.mock import AsyncMock, MagicMock, patch, ANY
 from pathlib import Path
 
-from pydoll.constants import By, RequestStage, ResourceType
+from pydoll.constants import By, RequestStage, ResourceType, RequestMethod
 from pydoll.browser.tab import Tab
 from pydoll.exceptions import (
     NoDialogPresent,
@@ -1214,7 +1214,7 @@ class TestTabRequestManagement:
 
     @pytest.mark.asyncio
     async def test_continue_request(self, tab):
-        """Test continue_request method."""
+        """Test continue_request method with minimal parameters."""
         request_id = 'test_request_123'
 
         await tab.continue_request(request_id)
@@ -1229,6 +1229,13 @@ async def test_continue_request(self, tab):
         # Verify it's a FetchCommands.continue_request command
         assert command['method'] == 'Fetch.continueRequest'
         assert command['params']['requestId'] == request_id
+        # Verify optional parameters are None/not set
+        params = command['params']
+        assert params.get('url') is None
+        assert params.get('method') is None
+        assert params.get('postData') is None
+        assert params.get('headers') is None
+        assert params.get('interceptResponse') is None
 
     @pytest.mark.asyncio
     async def test_fail_request(self, tab):
@@ -1254,15 +1261,11 @@ async def test_fail_request(self, tab):
 
     @pytest.mark.asyncio
     async def test_fulfill_request(self, tab):
-        """Test fulfill_request method."""
+        """Test fulfill_request method with minimal parameters."""
         request_id = 'test_request_789'
         response_code = 200
-        response_headers = [{'name': 'Content-Type', 'value': 'application/json'}]
-        response_body = {'status': 'success', 'data': 'test'}
 
-        await tab.fulfill_request(
-            request_id, response_code, response_headers, response_body
-        )
+        await tab.fulfill_request(request_id, response_code)
 
         # Verify the command was executed with correct parameters
         assert_mock_called_at_least_once(tab._connection_handler)
@@ -1275,8 +1278,48 @@ async def test_fulfill_request(self, tab):
         assert command['method'] == 'Fetch.fulfillRequest'
         assert command['params']['requestId'] == request_id
         assert command['params']['responseCode'] == response_code
-        assert command['params']['responseHeaders'] == response_headers
-        assert command['params']['body'] == response_body
+        # Verify optional parameters are None/not set
+        params = command['params']
+        assert params.get('responseHeaders') is None
+        assert params.get('body') is None
+        assert params.get('responsePhrase') is None
+
+    @pytest.mark.asyncio
+    async def test_continue_request_with_all_params(self, tab):
+        """Test continue_request with all parameters."""
+        from pydoll.constants import RequestMethod
+        
+        request_id = 'test_request_456'
+        url = 'https://modified-example.com'
+        method = RequestMethod.POST
+        post_data = 'modified_data=test'
+        headers = [{'name': 'Authorization', 'value': 'Bearer token123'}]
+        intercept_response = True
+        
+        await tab.continue_request(
+            request_id=request_id,
+            url=url,
+            method=method,
+            post_data=post_data,
+            headers=headers,
+            intercept_response=intercept_response,
+        )
+        
+        # Verify the command was executed with correct parameters
+        assert_mock_called_at_least_once(tab._connection_handler)
+        
+        # Get the call arguments to verify the command
+        call_args = tab._connection_handler.execute_command.call_args_list[-1]
+        command = call_args[0][0]  # First argument is the command
+        
+        # Verify all parameters
+        params = command['params']
+        assert params['requestId'] == request_id
+        assert params['url'] == url
+        assert params['method'] == method
+        assert params['postData'] == post_data
+        assert params['headers'] == headers
+        assert params['interceptResponse'] == intercept_response
 
     @pytest.mark.asyncio
     async def test_continue_request_with_different_id(self, tab):
@@ -1309,6 +1352,38 @@ async def test_fail_request_with_different_error(self, tab):
         command = call_args[0][0]
         assert command['params']['errorReason'] == error_reason
 
+    @pytest.mark.asyncio
+    async def test_fulfill_request_with_all_params(self, tab):
+        """Test fulfill_request with all parameters."""
+        request_id = 'test_request_complete'
+        response_code = 200
+        response_headers = [{'name': 'Content-Type', 'value': 'application/json'}]
+        body = '{"status": "success", "data": "test"}'
+        response_phrase = 'OK'
+        
+        await tab.fulfill_request(
+            request_id=request_id,
+            response_code=response_code,
+            response_headers=response_headers,
+            body=body,
+            response_phrase=response_phrase,
+        )
+        
+        # Verify the command was executed with correct parameters
+        assert_mock_called_at_least_once(tab._connection_handler)
+        
+        # Get the call arguments to verify the command
+        call_args = tab._connection_handler.execute_command.call_args_list[-1]
+        command = call_args[0][0]  # First argument is the command
+        
+        # Verify all parameters
+        params = command['params']
+        assert params['requestId'] == request_id
+        assert params['responseCode'] == response_code
+        assert params['responseHeaders'] == response_headers
+        assert params['body'] == body
+        assert params['responsePhrase'] == response_phrase
+
     @pytest.mark.asyncio
     async def test_fulfill_request_with_different_status_code(self, tab):
         """Test fulfill_request with different status code."""