Merge pull request #185 from radiantly/win-tests

test: fix tests on Windows

Author: thalissonvs

.github/workflows/tests.yml

@@ -1,16 +1,17 @@
 name: PyDoll Tests
 
-on: 
+on:
   push:
   pull_request:
-    
+
 jobs:
   tests:
-    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
+        os: [ubuntu-latest, windows-latest]
         python-version: ["3.10", "3.11", "3.12", "3.13"]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}

tests/test_browser/test_browser_tab.py

@@ -949,7 +949,7 @@ async def test_expect_file_chooser_event_handler_path_objects(self, tab):
         from pathlib import Path
 
         files = [Path('documents/file1.txt'), Path('images/file2.jpg')]
-        expected_files = ['documents/file1.txt', 'images/file2.jpg']
+        expected_files = [str(file) for file in files]
 
         await self._test_event_handler_with_files(tab, files, expected_files, 54321)
 
@@ -959,7 +959,7 @@ async def test_expect_file_chooser_event_handler_single_path_object(self, tab):
         from pathlib import Path
 
         files = Path('documents/important.pdf')
-        expected_files = ['documents/important.pdf']
+        expected_files = [str(files)]
 
         await self._test_event_handler_with_files(tab, files, expected_files, 98765)
 

tests/test_utils.py

@@ -3,6 +3,7 @@
 from aioresponses import aioresponses
 import tempfile
 import os
+import sys
 from unittest.mock import patch
 
 from pydoll import exceptions
@@ -189,6 +190,7 @@ def test_validate_browser_paths_no_valid_paths(self):
 
         assert 'No valid browser path found in:' in str(exc_info.value)
 
+    @pytest.mark.skipif(sys.platform.startswith('win'), reason='No executable bit on NTFS on Windows')
     def test_validate_browser_paths_file_exists_but_not_executable(self):
         """
         Test validate_browser_paths with non-executable file.
@@ -200,7 +202,7 @@ def test_validate_browser_paths_file_exists_but_not_executable(self):
             with open(non_executable, 'w') as f:
                 f.write('not executable')
             # Don't set executable permissions
-            
+
             with pytest.raises(exceptions.InvalidBrowserPath):
                 validate_browser_paths([non_executable])