remove missing block cache

Author: patrick-ogrady

vms/components/missing/block.go

@@ -12,7 +12,7 @@ import (
 )
 
 var (
-	ErrMissingBlock = errors.New("missing block")
+	errMissingBlock = errors.New("missing block")
 )
 
 // Block represents a block that can't be found
@@ -25,10 +25,10 @@ func (mb *Block) ID() ids.ID { return mb.BlkID }
 func (mb *Block) Height() uint64 { return 0 }
 
 // Accept ...
-func (*Block) Accept() error { return ErrMissingBlock }
+func (*Block) Accept() error { return errMissingBlock }
 
 // Reject ...
-func (*Block) Reject() error { return ErrMissingBlock }
+func (*Block) Reject() error { return errMissingBlock }
 
 // Status ...
 func (*Block) Status() choices.Status { return choices.Unknown }
@@ -37,7 +37,7 @@ func (*Block) Status() choices.Status { return choices.Unknown }
 func (*Block) Parent() snowman.Block { return nil }
 
 // Verify ...
-func (*Block) Verify() error { return ErrMissingBlock }
+func (*Block) Verify() error { return errMissingBlock }
 
 // Bytes ...
 func (*Block) Bytes() []byte { return nil }

vms/rpcchainvm/vm_client.go

@@ -47,7 +47,6 @@ var (
 
 const (
 	decidedCacheSize = 500
-	missingCacheSize = 500
 )
 
 // VMClient is an implementation of VM that talks over RPC.
@@ -70,7 +69,6 @@ type VMClient struct {
 	blks map[ids.ID]*BlockClient
 
 	decidedBlocks cache.Cacher
-	missingBlocks cache.Cacher
 
 	lastAccepted ids.ID
 }
@@ -103,16 +101,6 @@ func (vm *VMClient) initializeCaches(registerer prometheus.Registerer, namespace
 	}
 	vm.decidedBlocks = decidedCache
 
-	missingCache, err := metercacher.New(
-		fmt.Sprintf("%s_rpcchainvm_missing_cache", namespace),
-		registerer,
-		&cache.LRU{Size: missingCacheSize},
-	)
-	if err != nil {
-		return fmt.Errorf("could not initialize missing blocks cache: %w", err)
-	}
-	vm.missingBlocks = missingCache
-
 	return nil
 }
 
@@ -301,8 +289,6 @@ func (vm *VMClient) BuildBlock() (snowman.Block, error) {
 	parentID, err := ids.ToID(resp.ParentID)
 	vm.ctx.Log.AssertNoError(err)
 
-	vm.missingBlocks.Evict(id)
-
 	return &BlockClient{
 		vm:       vm,
 		id:       id,
@@ -331,7 +317,6 @@ func (vm *VMClient) ParseBlock(bytes []byte) (snowman.Block, error) {
 	if blkIntf, cached := vm.decidedBlocks.Get(id); cached {
 		return blkIntf.(*BlockClient), nil
 	}
-	vm.missingBlocks.Evict(id)
 
 	parentID, err := ids.ToID(resp.ParentID)
 	vm.ctx.Log.AssertNoError(err)
@@ -363,17 +348,10 @@ func (vm *VMClient) GetBlock(id ids.ID) (snowman.Block, error) {
 		return blkIntf.(*BlockClient), nil
 	}
 
-	if _, cached := vm.missingBlocks.Get(id); cached {
-		return nil, missing.ErrMissingBlock
-	}
-
 	resp, err := vm.client.GetBlock(context.Background(), &vmproto.GetBlockRequest{
 		Id: id[:],
 	})
 	if err != nil {
-		if errors.Is(err, missing.ErrMissingBlock) {
-			vm.missingBlocks.Put(id, struct{}{})
-		}
 		return nil, err
 	}