added comments

StephenButtolph · StephenButtolph · commit c73ba45812cb · 2021-02-12T00:09:42.000-05:00
diff --git a/chains/atomic/shared_memory.go b/chains/atomic/shared_memory.go
@@ -276,6 +276,7 @@ func (s *state) RemoveValue(key []byte) error {
 		return s.valueDB.Put(key, valueBytes)
 	}
 
+	// Don't allow the removal of something that was already removed.
 	if !value.Present {
 		return errDuplicatedOperation
 	}
diff --git a/snow/engine/snowman/transitive.go b/snow/engine/snowman/transitive.go
@@ -480,6 +480,9 @@ func (t *Transitive) issueFrom(vdr ids.ShortID, blk snowman.Block) (bool, error)
 
 	issued := t.Consensus.Issued(blk)
 	if issued {
+		// A dependency should never be waiting on an issued block. However, if
+		// the block was marked as rejected by the VM, the dependencies may
+		// still be waiting. Therefore, they should abandoned.
 		t.blocked.Abandon(blkID)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -276,6 +276,7 @@ func (s *state) RemoveValue(key []byte) error {`
`276`	`276`	`return s.valueDB.Put(key, valueBytes)`
`277`	`277`	`}`
`278`	`278`
	`279`	`+ // Don't allow the removal of something that was already removed.`
`279`	`280`	`if !value.Present {`
`280`	`281`	`return errDuplicatedOperation`
`281`	`282`	`}`
Original file line number	Diff line number	Diff line change
`@@ -480,6 +480,9 @@ func (t *Transitive) issueFrom(vdr ids.ShortID, blk snowman.Block) (bool, error)`
`480`	`480`
`481`	`481`	`issued := t.Consensus.Issued(blk)`
`482`	`482`	`if issued {`
	`483`	`+ // A dependency should never be waiting on an issued block. However, if`
	`484`	`+ // the block was marked as rejected by the VM, the dependencies may`
	`485`	`+ // still be waiting. Therefore, they should abandoned.`
`483`	`486`	`t.blocked.Abandon(blkID)`
`484`	`487`	`}`
`485`	`488`