Provide alternative to gossip.BloomFilter
#4545
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
StephenButtolph
commented
Nov 25, 2025
| if err := s.set.Add(v); err != nil { | ||
| return err | ||
| } | ||
| return s.AddToBloom(v.GossipID()) |
Contributor
Author
There was a problem hiding this comment.
TODO: Should this return the error? Or should this just log a warning. The value was added to the inner set and to the bloom filter... So it might make more sense to just log and move on.
StephenButtolph
force-pushed
the
cleanup-gossip-package
branch
2 times, most recently
from
fff1ca2 to
4e80be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
gossip.BloomFilteris fairly tough to use as it is only partially thread safe (and requires external synchronization primitives with the underlying mempool.This provides a single implementation that abstracts the usage of a bloom filter away from the VM (unless the VM is doing something weird, like the X-chain).
How this works
Implements a
gossip.SetWithBloomFilterimplementation that hides the bloom filter from the VM and uses it rather than usinggossip.BloomFilter.How this was tested
Unit tests + existing e2e tests
Need to be documented in RELEASES.md?
No