error on rand fail

Author: JonathanOppenheimer

network/peer_tracker.go

@@ -77,7 +77,13 @@ func (p *peerTracker) shouldTrackNewPeer() bool {
 		return false
 	}
 	newPeerProbability := math.Exp(-float64(numResponsivePeers) * newPeerConnectFactor)
-	return rand.SecureFloat64() < newPeerProbability
+	randomValue, err := rand.SecureFloat64()
+	if err != nil {
+		log.Error("failed to generate secure random number for peer tracking", "err", err)
+		// Fallback to conservative behavior - don't track new peer
+		return false
+	}
+	return randomValue < newPeerProbability
 }
 
 // getResponsivePeer returns a random [ids.NodeID] of a peer that has responded
@@ -116,7 +122,12 @@ func (p *peerTracker) GetAnyPeer(minVersion *version.Application) (ids.NodeID, b
 		random   bool
 		averager safemath.Averager
 	)
-	if rand.SecureFloat64() < randomPeerProbability {
+	randomValue, err := rand.SecureFloat64()
+	if err != nil {
+		log.Error("failed to generate secure random number for peer selection", "err", err)
+		// Fallback to deterministic behavior - use bandwidth heap
+		nodeID, averager, ok = p.bandwidthHeap.Pop()
+	} else if randomValue < randomPeerProbability {
 		random = true
 		nodeID, averager, ok = p.getResponsivePeer()
 	} else {

utils/rand/rand.go

@@ -13,16 +13,20 @@ import (
 
 // Intn is a shortcut for generating a random integer between 0 and
 // n using crypto/rand.
-func Intn(n int64) int64 {
+func Intn(n int64) (int64, error) {
 	nBig, err := rand.Int(rand.Reader, big.NewInt(n))
 	if err != nil {
-		panic(err)
+		return 0, err
 	}
-	return nBig.Int64()
+	return nBig.Int64(), nil
 }
 
 // SecureFloat64 is a shortcut for generating a random float between 0 and
 // 1 using crypto/rand.
-func SecureFloat64() float64 {
-	return float64(Intn(1<<53)) / (1 << 53)
+func SecureFloat64() (float64, error) {
+	n, err := Intn(1 << 53)
+	if err != nil {
+		return 0, err
+	}
+	return float64(n) / (1 << 53), nil
 }