refactor: e2es and anything else that remains #14236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCat567
changed the title
added 11 commits
October 22, 2025 12:57
ShadowCat567
changed the title
ShadowCat567
changed the title
added 13 commits
October 27, 2025 12:04
ShadowCat567
commented
Oct 28, 2025
Contributor
Author
|
Passing e2e run: https://tiny.amazon.com/18bzvkw3i/IsenLink |
svidgen
previously approved these changes
Oct 29, 2025
added 2 commits
October 29, 2025 14:57
… into sdk-migrations-2
svidgen
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating:
Removed 2 files:
packages/amplify-e2e-tests/functions/dynamodb-scan-v2.js-- tested the Scan Command in DynamoDB in AWS SDK V2. This is not being used by any files, removed itpackages/amplify-provider-awscloudformation/src/aws-utils/aws.js-- this used to be the heart of the AWS SDK V2 configuration in theamplify-provider-awscloudformationpackage. Since everything has been migrated to V2, nothing uses this any more.Changes to CodeBuild Clean up Script:
Removed functionality to check whether a Codebuild job is currently running before deleting its resources. The overhead of getting information about Codebuild jobs to see whether they were completed or not was consuming too much memory ever since the migration to V3.
The Codebuild spec for our e2e tests already ensures that the clean up resources job does not run until all the other jobs have been completed and the cleanup script already skips cleaning up stacks that were created in the last 2 hours, so I think we are safe to remove this functionality for better memory usage.
Had to downgrade pinpoint-client back to an older version since the newest versions seem to break some of our notifications e2e tests.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.