Skip to content

Commit 4f0c69d

Browse files
committed
Merge branch 'fix/missing-dep' into 'develop'
fix: add missing docs_service dependency group in idp_common_pkg setup.py and add check for Python 3.12 See merge request genaiic-reusable-assets/engagement-artifacts/genaiic-idp-accelerator!200
2 parents cc05c60 + 21bcc22 commit 4f0c69d

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

lib/idp_common_pkg/setup.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@
5151
"appsync": [
5252
"requests==2.32.4",
5353
],
54+
# Document service factory dependencies (includes both appsync and dynamodb support)
55+
"docs_service": [
56+
"requests==2.32.4",
57+
],
5458
# Testing dependencies
5559
"test": [
5660
"pytest>=7.4.0",

publish.sh

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,20 @@ function check_prerequisites() {
100100
exit 1
101101
fi
102102

103+
# Check Python version
104+
if command -v python3 &>/dev/null; then
105+
local python_version=$(python3 -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')
106+
local min_python_version="3.12"
107+
if [[ $(echo -e "$min_python_version\n$python_version" | sort -V | head -n1) != $min_python_version ]]; then
108+
echo "Error: Python version >= $min_python_version is required. (Installed version is $python_version)" >&2
109+
echo "Please upgrade your Python installation." >&2
110+
exit 1
111+
fi
112+
else
113+
echo "Error: Python 3 is not installed or not in PATH" >&2
114+
exit 1
115+
fi
116+
103117
# Set platform-specific commands
104118
if [[ $(uname -m) == "x86_64" ]]; then
105119
USE_CONTAINER_FLAG=""

0 commit comments

Comments
 (0)