From 086aaf378ef0b30248433db29fd5804f7e3d8a61 Mon Sep 17 00:00:00 2001 From: Bret Ambrose Date: Wed, 2 Jul 2025 12:40:48 -0700 Subject: [PATCH 1/3] Why was this using mqtt5 publish completion contract? --- samples/basic_discovery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/basic_discovery.py b/samples/basic_discovery.py index 8998a977..269f0ad5 100644 --- a/samples/basic_discovery.py +++ b/samples/basic_discovery.py @@ -104,7 +104,7 @@ def on_publish(topic, payload, dup, qos, retain, **kwargs): messageJson = json.dumps(message) pub_future, _ = mqtt_connection.publish(cmdData.input_topic, messageJson, QoS.AT_LEAST_ONCE) publish_completion_data = pub_future.result() - print('Published topic {}: {} (puback reason: {})\n'.format(cmdData.input_topic, messageJson, repr(publish_completion_data.puback.reason_code))) + print('Successfully published to topic {} with payload `{}`\n'.format(cmdData.input_topic, messageJson)) loop_count += 1 time.sleep(1) From 5d1e66d5a67193b1275367d9c205a03149ddd40b Mon Sep 17 00:00:00 2001 From: Bret Ambrose Date: Wed, 24 Sep 2025 10:54:13 -0700 Subject: [PATCH 2/3] Remove deprecated direct invocations of setup.py in favor of build; misc updates --- .github/workflows/ci.yml | 6 +++--- .github/workflows/release.yml | 2 +- codebuild/cd/publish-to-prod-pypi.yml | 4 ++-- codebuild/cd/publish-to-test-pypi.yml | 4 ++-- setup.py | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aff88807..927c6b78 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')" python builder.pyz build -p ${{ env.PACKAGE_NAME }} - name: configure AWS credentials (MQTT5) - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: role-to-assume: ${{ env.CI_MQTT5_ROLE }} aws-region: ${{ env.AWS_DEFAULT_REGION }} @@ -130,7 +130,7 @@ jobs: chmod a+x builder ./builder build -p ${{ env.PACKAGE_NAME }} - name: configure AWS credentials (MQTT5) - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: role-to-assume: ${{ env.CI_MQTT5_ROLE }} aws-region: ${{ env.AWS_DEFAULT_REGION }} @@ -202,7 +202,7 @@ jobs: chmod a+x builder ./builder build -p ${{ env.PACKAGE_NAME }} - name: configure AWS credentials (MQTT5) - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: role-to-assume: ${{ env.CI_MQTT5_ROLE }} aws-region: ${{ env.AWS_DEFAULT_REGION }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ff3e36d0..5d79edd1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -68,7 +68,7 @@ jobs: force: true - name: configure AWS credentials (Release) - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: role-to-assume: arn:aws:iam::180635532705:role/CI_V2_RELEASE_S3_ROLE aws-region: us-east-1 diff --git a/codebuild/cd/publish-to-prod-pypi.yml b/codebuild/cd/publish-to-prod-pypi.yml index 859c0cbc..3ec776f5 100644 --- a/codebuild/cd/publish-to-prod-pypi.yml +++ b/codebuild/cd/publish-to-prod-pypi.yml @@ -11,7 +11,7 @@ phases: - sudo apt-get install python3 python3-pip -y - export PATH=$PATH:$HOME/.local/bin - python3 -m pip install --user --upgrade pip - - python3 -m pip install --user --upgrade twine setuptools wheel awscli PyOpenSSL six + - python3 -m pip install --user --upgrade twine awscli build setuptools - echo "\nBuild version data:" - echo "\nPython Version:"; python3 --version pre_build: @@ -24,7 +24,7 @@ phases: build: commands: - echo Build started on `date` - - python3 setup.py sdist bdist_wheel + - python3 -m build - python3 -m twine upload -r pypi dist/* post_build: commands: diff --git a/codebuild/cd/publish-to-test-pypi.yml b/codebuild/cd/publish-to-test-pypi.yml index 9450aa80..75e6ea97 100644 --- a/codebuild/cd/publish-to-test-pypi.yml +++ b/codebuild/cd/publish-to-test-pypi.yml @@ -11,7 +11,7 @@ phases: - sudo apt-get install python3 python3-pip -y - export PATH=$PATH:$HOME/.local/bin - python3 -m pip install --user --upgrade pip - - python3 -m pip install --user --upgrade twine setuptools wheel awscli PyOpenSSL six + - python3 -m pip install --user --upgrade twine awscli build setuptools - echo "\nBuild version data:" - echo "\nPython Version:"; python3 --version pre_build: @@ -24,7 +24,7 @@ phases: build: commands: - echo Build started on `date` - - python3 setup.py sdist bdist_wheel + - python3 -m build - python3 -m twine upload -r testpypi dist/* post_build: commands: diff --git a/setup.py b/setup.py index 98327934..5c312a6a 100644 --- a/setup.py +++ b/setup.py @@ -42,5 +42,5 @@ def _load_version(): install_requires=[ 'awscrt==0.27.4', ], - python_requires='>=3.7', + python_requires='>=3.8', ) From 9d98d489c605dc561cfcbd80a7ee2521fbbeda80 Mon Sep 17 00:00:00 2001 From: Bret Ambrose Date: Wed, 24 Sep 2025 11:08:11 -0700 Subject: [PATCH 3/3] Update builder version to maybe fix clang version assertion --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 927c6b78..44091667 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ on: - 'docs' env: - BUILDER_VERSION: v0.9.56 + BUILDER_VERSION: v0.9.87 BUILDER_SOURCE: releases BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net PACKAGE_NAME: aws-iot-device-sdk-python-v2