Skip to content

Commit 94505c3

Browse files
committed
chore(codegen): remove checks for deprecated SetShape
1 parent ff5b376 commit 94505c3

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/JsonShapeDeserVisitor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import software.amazon.smithy.model.traits.MediaTypeTrait;
3737
import software.amazon.smithy.model.traits.SparseTrait;
3838
import software.amazon.smithy.model.traits.TimestampFormatTrait.Format;
39+
import software.amazon.smithy.model.traits.UniqueItemsTrait;
3940
import software.amazon.smithy.typescript.codegen.CodegenUtils;
4041
import software.amazon.smithy.typescript.codegen.TypeScriptDependency;
4142
import software.amazon.smithy.typescript.codegen.TypeScriptSettings.ArtifactType;
@@ -123,7 +124,7 @@ protected void deserializeCollection(GenerationContext context, CollectionShape
123124
);
124125
}
125126

126-
if (shape.isSetShape() && artifactType.equals(ArtifactType.SSDK)) {
127+
if (shape.isListShape() && shape.hasTrait(UniqueItemsTrait.ID) && artifactType.equals(ArtifactType.SSDK)) {
127128
writer.addDependency(TypeScriptDependency.SERVER_COMMON);
128129
writer.addImport("findDuplicates", "__findDuplicates", "@aws-smithy/server-common");
129130
writer.openBlock("if (__findDuplicates(retVal).length > 0) {", "}", () -> {

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/QueryMemberSerVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ final class QueryMemberSerVisitor extends DocumentMemberSerVisitor {
3939

4040
boolean visitSuppliesEntryList(Shape shape) {
4141
return shape.isStructureShape() || shape.isUnionShape()
42-
|| shape.isMapShape() || shape.isListShape() || shape.isSetShape();
42+
|| shape.isMapShape() || shape.isListShape();
4343
}
4444

4545
@Override

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/QueryShapeSerVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ private void serializeNamedMemberEntryList(
275275

276276
Shape targetShape = context.getModel().expectShape(memberShape.getTarget());
277277

278-
if ((targetShape.isListShape() || targetShape.isSetShape()) && serializeEmptyLists) {
278+
if (targetShape.isListShape() && serializeEmptyLists) {
279279
writer.openBlock(
280280
"if ($L?.length === 0) {",
281281
"}",

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/visitor/MemberDeserVisitor.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import software.amazon.smithy.model.shapes.OperationShape;
2929
import software.amazon.smithy.model.shapes.ResourceShape;
3030
import software.amazon.smithy.model.shapes.ServiceShape;
31-
import software.amazon.smithy.model.shapes.SetShape;
3231
import software.amazon.smithy.model.shapes.Shape;
3332
import software.amazon.smithy.model.shapes.ShapeVisitor;
3433
import software.amazon.smithy.model.shapes.ShortShape;
@@ -199,11 +198,6 @@ public final String mapShape(MapShape shape) {
199198
return getDelegateDeserializer(shape);
200199
}
201200

202-
@Override
203-
public final String setShape(SetShape shape) {
204-
return getDelegateDeserializer(shape);
205-
}
206-
207201
@Override
208202
public final String structureShape(StructureShape shape) {
209203
return getDelegateDeserializer(shape);

0 commit comments

Comments
 (0)