fix: SpotBugs errors

Author: ThirdEyeSqueegee

src/main/java/com/amazonaws/secretsmanager/caching/SecretCache.java

@@ -140,8 +140,8 @@ public String getSecretString(final String secretId) {
      * Retrieve and cache a secret string from AWS Secrets Manager.
      *
      * @param secretId the secret ID of the desired secret.
-     * @param versionId the version ID of the desired secret (optional, can be <c>null</c>).
-     * @param versionStage the version stage of the desired secret (optional, can be <c>null</c>).
+     * @param versionId the version ID of the desired secret (optional, can be null).
+     * @param versionStage the version stage of the desired secret (optional, can be null).
      *
      * @return The secret string for the desired secret.
      */
@@ -175,8 +175,8 @@ public ByteBuffer getSecretBinary(final String secretId) {
      * Retrieve and cache a secret binary from AWS Secrets Manager.
      *
      * @param secretId the secret ID of the desired secret.
-     * @param versionId the version ID of the desired secret (optional, can be <c>null</c>).
-     * @param versionStage the version stage of the desired secret (optional, can be <c>null</c>).
+     * @param versionId the version ID of the desired secret (optional, can be null).
+     * @param versionStage the version stage of the desired secret (optional, can be null).
      *
      * @return The secret binary for the desired secret.
      */

src/main/java/com/amazonaws/secretsmanager/caching/cache/SecretCacheItem.java

@@ -132,7 +132,7 @@ private SecretCacheVersion getVersion(DescribeSecretResponse describeResponse, S
                 continue;
             }
 
-            if (versionId != null && entry.getKey() == versionId) {
+            if (versionId != null && versionId.equals(entry.getKey())) {
                 currentVersionId = Optional.of(versionId);
                 break;
             }
@@ -174,8 +174,8 @@ protected GetSecretValueResponse getSecretValue(DescribeSecretResponse describeR
      * Return the cached GetSecretValue result.
      *
      * @param describeResponse the DescribeSecret result.
-     * @param versionId the version ID of the desired secret (optional, can be <c>null</c>).
-     * @param versionStage the version stage of the desired secret (optional, can be <c>null</c>).
+     * @param versionId the version ID of the desired secret (optional, can be null).
+     * @param versionStage the version stage of the desired secret (optional, can be null).
      *
      * @return The cached GetSecretValue result.
      */

src/main/java/com/amazonaws/secretsmanager/caching/cache/SecretCacheObject.java

@@ -122,8 +122,8 @@ public SecretCacheObject(final String secretId,
      * Execute the actual refresh of the cached secret state.
      *
      * @param result the GetSecretValue or DescribeSecret result.
-     * @param versionId the version ID of the desired secret (optional, can be <c>null</c>).
-     * @param versionStage the version stage of the desired secret (optional, can be <c>null</c>).
+     * @param versionId the version ID of the desired secret (optional, can be null).
+     * @param versionStage the version stage of the desired secret (optional, can be null).
      *
      * @return The cached GetSecretValue result based on the current cached state.
      */
@@ -266,8 +266,8 @@ public GetSecretValueResponse getSecretValue() {
     /**
      * Return the cached GetSecretValue result.
      *
-     * @param versionId the version ID of the desired secret (optional, can be <c>null</c>).
-     * @param versionStage the version stage of the desired secret (optional, can be <c>null</c>).
+     * @param versionId the version ID of the desired secret (optional, can be null).
+     * @param versionStage the version stage of the desired secret (optional, can be null).
      *
      * @return The cached GetSecretValue result.
      */

src/main/java/com/amazonaws/secretsmanager/caching/cache/SecretCacheVersion.java

@@ -102,8 +102,8 @@ protected GetSecretValueResponse getSecretValue(GetSecretValueResponse gsvResult
      * Return the cached GetSecretValue result.
      *
      * @param gsvResult the GetSecretValue or DescribeSecret result.
-     * @param versionId the version ID of the desired secret (optional, can be <c>null</c>).
-     * @param versionStage the version stage of the desired secret (optional, can be <c>null</c>).
+     * @param versionId the version ID of the desired secret (optional, can be null).
+     * @param versionStage the version stage of the desired secret (optional, can be null).
      *
      * @return The cached GetSecretValue result.
      */