Skip to content

Commit 103c50d

Browse files
author
Konrad Dysput
committed
react-native: Bring standard serialization method, formatting and fix environment variable read
1 parent 298b740 commit 103c50d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

examples/sdk/reactNative/ios-sourcemap-upload.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ fi
2828

2929
DEBUG_ID_PATH_ENV="DEBUG_ID_PATH"
3030

31-
debug_id_file_path=${!DEBUG_ID_PATH_ENV:-${2:-}}
31+
debug_id_file_path=${DEBUG_ID_PATH_ENV:-${2:-}}
3232

3333
if [ ! -f "$debug_id_file_path" ]; then
3434
echo "Error: File '$debug_id_file_path' does not exist."

examples/sdk/reactNative/ios/reactNative.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269
);
270270
runOnlyForDeploymentPostprocessing = 0;
271271
shellPath = /bin/sh;
272-
shellScript = "set -e\nexport SOURCEMAP_FILE=\"$(pwd)/../main.jsbundle.map\"\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n\nsource_map_upload=\"$(pwd)/../ios-sourcemap-upload.sh\"\nbacktrace_js_config=\"$(pwd)/../.backtracejsrc\"\n/bin/sh -c \"$source_map_upload $SOURCEMAP_FILE $TARGET_BUILD_DIR/.backtrace-sourcemap-id $backtrace_js_config\" \n\n";
272+
shellScript = "set -e\n# enable source map support\nexport SOURCEMAP_FILE=\"$(pwd)/../main.jsbundle.map\"\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n\n# upload source maps to Backtrace\nsource_map_upload=\"$(pwd)/../ios-sourcemap-upload.sh\"\nbacktrace_js_config=\"$(pwd)/../.backtracejsrc\"\n/bin/sh -c \"$source_map_upload $SOURCEMAP_FILE $TARGET_BUILD_DIR/.backtrace-sourcemap-id $backtrace_js_config\" \n\n";
273273
};
274274
00EEFC60759A1932668264C0 /* [CP] Embed Pods Frameworks */ = {
275275
isa = PBXShellScriptBuildPhase;

examples/sdk/reactNative/metro.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const config = {
1616
path.resolve('../../../packages/sdk-core'),
1717
],
1818
serializer: {
19-
customSerializer: backtraceSourceMapProcessor.processSourceMap
19+
customSerializer: backtraceSourceMapProcessor.processSourceMap,
2020
},
2121
};
2222
module.exports = mergeConfig(getDefaultConfig(__dirname), config);

packages/react-native/android/upload-sourcemaps.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ tasks.register("uploadSourceMapsToBacktrace") {
3636
def mapData = jsonSlurper.parse(mapFile)
3737
mapData.debugId = debugIdFile.text
3838
def jsonBuilder = new JsonBuilder(mapData)
39-
mapFile.text = jsonBuilder.toPrettyString()
39+
mapFile.text = jsonBuilder.toString()
4040

4141
// Execute Backtrace JS CLI to process upload processed source maps
4242
def command = ["npx", "--yes", "@backtrace/javascript-cli", "upload", "-p", mapFile.absolutePath]

0 commit comments

Comments
 (0)