Skip to content

Commit 415c37c

Browse files
authored
electron: reduce breadcrumb size (#231)
* electron: use factory in IpcBreadcrumbsStorage * electron: pass fileSystem to FileBreadcrumbsStorage.getSessionAttachments --------- Co-authored-by: Sebastian Alex <sebastian.alex@saucelabs.com>
1 parent 2e5743b commit 415c37c

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

packages/electron/src/main/modules/BacktraceMainElectronModule.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ export class BacktraceMainElectronModule implements BacktraceModule {
173173

174174
const fileAttachmentsManager = FileAttachmentsManager.createFromSession(session, fileSystem);
175175
const sessionAttachments = [
176-
...FileBreadcrumbsStorage.getSessionAttachments(session),
176+
...FileBreadcrumbsStorage.getSessionAttachments(session, fileSystem),
177177
...(await fileAttachmentsManager.get()),
178178
];
179179

packages/electron/src/renderer/addBacktraceElectron.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export function addBacktraceElectron<T extends BacktraceCoreClientBuilder>(
5656
builder
5757
.useRequestHandler(new IpcRequestHandler(ipcRpc))
5858
.useReportSubmission(new IpcReportSubmission(ipcRpc, ipcTransport))
59-
.useBreadcrumbsStorage(new IpcBreadcrumbsStorage(ipcTransport))
59+
.useBreadcrumbsStorage(IpcBreadcrumbsStorage.factory(ipcTransport))
6060
.useSummedMetricsQueue(new IpcSummedMetricsQueue(ipcTransport, ipcRpc))
6161
.useUniqueMetricsQueue(new StubMetricsQueue());
6262

packages/electron/src/renderer/modules/IpcBreadcrumbsStorage.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ import { IpcEvents } from '../../common/ipc/IpcEvents.js';
55
export class IpcBreadcrumbsStorage implements BreadcrumbsStorage {
66
constructor(private readonly _ipcTransport: IpcTransport) {}
77

8+
public static factory(transport: IpcTransport) {
9+
return () => new IpcBreadcrumbsStorage(transport);
10+
}
11+
812
public get lastBreadcrumbId(): number {
913
return -1;
1014
}

0 commit comments

Comments
 (0)