Skip to content

Commit 4c9c1b0

Browse files
author
Konrad Dysput
committed
react-native: move scripts into the script directory and adjust paths to them in readme/xcode
1 parent ee97e7f commit 4c9c1b0

File tree

6 files changed

+13
-10
lines changed

6 files changed

+13
-10
lines changed

examples/sdk/reactNative/README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ Before executing any step:
1616

1717
> Please update .backtracejsrc file with your symbols submission URL and your sourcemap settings.
1818
19-
Backtrace is compatible with metro build system. To enable source map support, set a `customSerializer` method in the `metro.config.js` file to the `processSourceMap` function available in `@backtrace/react-native/processSourceMap`.
19+
Backtrace is compatible with metro build system. To enable source map support, set a `customSerializer` method in the `metro.config.js` file to the `processSourceMap` function available in `@backtrace/react-native/scripts/processSourceMap`.
2020

2121
```
2222
const { getDefaultConfig, mergeConfig } = require('@react-native/metro-config');
23-
const backtraceSourceMapProcessor = require('@backtrace/react-native/processSourceMap');
23+
const backtraceSourceMapProcessor = require('@backtrace/react-native/scripts/processSourceMap');
2424
2525
const config = {
2626
serializer: {
@@ -56,13 +56,16 @@ tasks.matching {
5656
Modify the code in the `Bundle React Native code and images` step in the `Build Phases` of your xcode project setting. In the end of the script, you can include the code below, to upload source maps directly to Backtrace after generating the applicaiton.
5757

5858
```bash
59+
project_directory="$(pwd)/.."
5960
# enable source map support
60-
export SOURCEMAP_FILE="$(pwd)/../main.jsbundle.map"
61+
export SOURCEMAP_FILE="$project_directory/main.jsbundle.map"
6162

6263
...
6364

6465
# upload source maps to Backtrace
65-
source_map_upload="$(pwd)/../ios-sourcemap-upload.sh"
66-
backtrace_js_config="$(pwd)/../.backtracejsrc"
67-
/bin/sh -c "$source_map_upload $SOURCEMAP_FILE $TARGET_BUILD_DIR/.backtrace-sourcemap-id $backtrace_js_config"
66+
source_map_upload="$project_directory/node_modules/@backtrace/react-native/scripts/ios-sourcemap-upload.sh"
67+
backtrace_js_config="$project_directory/.backtracejsrc"
68+
69+
/bin/sh -c "$source_map_upload $SOURCEMAP_FILE $TARGET_BUILD_DIR/.backtrace-sourcemap-id $backtrace_js_config $project_directory"
70+
6871
```

examples/sdk/reactNative/ios/reactNative.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269
);
270270
runOnlyForDeploymentPostprocessing = 0;
271271
shellPath = /bin/sh;
272-
shellScript = "set -e\nproject_directory=\"$(pwd)/..\"\n# enable source map support\nexport SOURCEMAP_FILE=\"$project_directory/main.jsbundle.map\"\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n\n# upload source maps to Backtrace\nsource_map_upload=\"$project_directory/node_modules/@backtrace/react-native/ios-sourcemap-upload.sh\"\nbacktrace_js_config=\"$project_directory/.backtracejsrc\"\n\n/bin/sh -c \"$source_map_upload $SOURCEMAP_FILE $TARGET_BUILD_DIR/.backtrace-sourcemap-id $backtrace_js_config $project_directory\" \n\n";
272+
shellScript = "set -e\nproject_directory=\"$(pwd)/..\"\n# enable source map support\nexport SOURCEMAP_FILE=\"$project_directory/main.jsbundle.map\"\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n\n# upload source maps to Backtrace\nsource_map_upload=\"$project_directory/node_modules/@backtrace/react-native/scripts/ios-sourcemap-upload.sh\"\nbacktrace_js_config=\"$project_directory/.backtracejsrc\"\n\n/bin/sh -c \"$source_map_upload $SOURCEMAP_FILE $TARGET_BUILD_DIR/.backtrace-sourcemap-id $backtrace_js_config $project_directory\" \n\n";
273273
};
274274
00EEFC60759A1932668264C0 /* [CP] Embed Pods Frameworks */ = {
275275
isa = PBXShellScriptBuildPhase;

examples/sdk/reactNative/metro.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const { getDefaultConfig, mergeConfig } = require('@react-native/metro-config');
22
const path = require('path');
3-
const backtraceSourceMapProcessor = require('@backtrace/react-native/processSourceMap');
3+
const backtraceSourceMapProcessor = require('@backtrace/react-native/scripts/processSourceMap');
44

55
/**
66
* Metro configuration

packages/react-native/processSourceMap.js renamed to packages/react-native/scripts/processSourceMap.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const DEBUG_ID_PATH = process.env.DEBUG_ID_PATH;
1010
/**
1111
* Process metro build with source map support powered by Backtrace.
1212
*/
13-
function processSourceMap(entryPoint, preModules, graph, options) {
13+
async function processSourceMap(entryPoint, preModules, graph, options) {
1414
const bundle = bundleToString(baseJSBundle(entryPoint, preModules, graph, options));
1515

1616
// development build - skip source map upload
@@ -30,7 +30,7 @@ function processSourceMap(entryPoint, preModules, graph, options) {
3030

3131
const debugIdGenerator = new DebugIdGenerator();
3232
const sourceProcessor = new SourceProcessor(debugIdGenerator);
33-
const { source, debugId } = sourceProcessor.processSource(bundle.code);
33+
const { source, debugId } = await sourceProcessor.processSource(bundle.code);
3434
const snippet = debugIdGenerator.generateSourceSnippet(debugId);
3535

3636
console.debug(`Backtrace: saving debugId ${debugId} to ${backtraceSourceMapId}.`);

0 commit comments

Comments
 (0)