react-native: Flow adjustements & Code review

Author: Konrad Dysput

examples/sdk/reactNative/ios-sourcemap-upload.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 # Script responsible for preprocessing source maps with debugid and uploading it to Backtrace via backtrace-js. 
-# Usage:    ./ios-sourcemap-upload.sh <source_map_file_path> <debug_id_file_path> <backtrace_configuration_path
+# Usage:    ./ios-sourcemap-upload.sh <source_map_file_path> <debug_id_file_path> <backtrace_configuration_path>
 # Parameters:
 #   <source_map_file_path>        (Required) Path to the source map file.
 #   <debug_id_file_path>            (Required) path to generated backtrace debug id.
@@ -44,7 +44,7 @@ backtrace_configuration_path="$3"
 
 debug_id=$(<"$debug_id_file_path")
 
-jq ". += {\"debugId\": \"$debug_id\"}" "$source_map_file_path" > tmp.map && mv tmp.map $source_map_file_path
+jq ". += {\"debugId\": \"$debug_id\"}" "$source_map_file_path" > "${source_map_file_path}.tmp" && mv "${source_map_file_path}.tmp" $source_map_file_path
 
 script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 

examples/sdk/reactNative/metro.config.js

@@ -16,9 +16,7 @@ const config = {
         path.resolve('../../../packages/sdk-core'),
     ],
     serializer: {
-        async customSerializer(entryPoint, preModules, graph, options) {
-            return backtraceSourceMapProcessor.processSourceMap(entryPoint, preModules, graph, options);
-        },
+        customSerializer: backtraceSourceMapProcessor.processSourceMap
     },
 };
 module.exports = mergeConfig(getDefaultConfig(__dirname), config);

packages/react-native/android/upload-sourcemaps.gradle

@@ -19,7 +19,7 @@ tasks.register("uploadSourceMapsToBacktrace") {
                 .asFile
 
         if (!debugIdFile.exists()) {
-            println("Backtrace: Cannot find .backtrace-sourcemap-id debug info.")
+            println("Backtrace: Cannot find .backtrace-sourcemap-id file. Check if customSerializer has been set to Backtrace serializer in metro.config.js.")
             return
         }