react-native: allow for unlimited breadcrumbs in FileBreadcrumbsStorage

Author: perf2711

packages/react-native/src/breadcrumbs/AlternatingFileWriter.ts

@@ -17,12 +17,9 @@ export class AlternatingFileWriter {
         private readonly _fileSystem: FileSystem,
         private readonly _mainFile: string,
         private readonly _fallbackFile: string,
-        private readonly _maxLines: number,
+        private readonly _maxLines?: number,
         private readonly _maxSize?: number,
     ) {
-        if (this._maxLines <= 0) {
-            throw new Error('File capacity may not be less or equal to 0.');
-        }
         this._streamWriter = this._fileSystem.streamWriter;
     }
 
@@ -72,11 +69,11 @@ export class AlternatingFileWriter {
 
             const logLength = log.length + 1;
 
-            if (currentCount + 1 > this._maxLines) {
+            if (currentCount + 1 > (this._maxLines ?? Infinity)) {
                 break;
             }
 
-            if (this._maxSize && currentSize + logLength >= this._maxSize) {
+            if (currentSize + logLength >= (this._maxSize ?? Infinity)) {
                 break;
             }
 
@@ -111,7 +108,7 @@ export class AlternatingFileWriter {
     private prepareBreadcrumbStream(newSize: number) {
         if (!this._streamId) {
             this._streamId = this._streamWriter.create(this._mainFile);
-        } else if (this._count >= this._maxLines || (this._maxSize && this._size + newSize >= this._maxSize)) {
+        } else if (this._count >= (this._maxLines ?? Infinity) || this._size + newSize >= (this._maxSize ?? Infinity)) {
             this.switchFile();
         }
     }

packages/react-native/src/breadcrumbs/FileBreadcrumbsStorage.ts

@@ -36,7 +36,7 @@ export class FileBreadcrumbsStorage implements BreadcrumbsStorage {
             _fileSystem,
             _mainFile,
             _fallbackFile,
-            Math.floor((this._limits.maximumBreadcrumbs ?? 100) / 2),
+            this._limits.maximumBreadcrumbs ? Math.floor(this._limits.maximumBreadcrumbs / 2) : undefined,
             this._limits.maximumTotalBreadcrumbsSize,
         );
     }