Include windows in CICD pipeline. Use @v4 (#249)

* Include windows in CICD pipeline. Use @v4

* Remove strategy

* Action name

* declare prettierrc path

* Correct path to the file

* Update prettier and options

* Set end of line to auto

* Apply default formatting proposed by prettier latest (#252)

* Apply default formatting proposed by prettier latest

* Force to use prettierrc.json

* Print file structure

* Escape file name

* Auto end of line

* Use powershell

* Correct YAML

* Use win-node-env

* Do not require powershell if not needed

* Remove changes that dont belong to this pull request

* use cross-env for setting NODE_ENV variables

* cli: fix test errors on Windows

* Apply formatting

---------

Co-authored-by: Sebastian Alex <sebastian.alex@saucelabs.com>

---------

Co-authored-by: Sebastian Alex <sebastian.alex@saucelabs.com>

Author: konraddysput

.github/workflows/test.yml

@@ -6,17 +6,17 @@ on:
     pull_request:
 
 jobs:
-    build:
+    test_linux:
         runs-on: ubuntu-latest
 
         strategy:
             matrix:
                 node-version: [16.x, 18.x, 20.x]
 
         steps:
-            - uses: actions/checkout@v3
+            - uses: actions/checkout@v4
             - name: Use Node.js ${{ matrix.node-version }}
-              uses: actions/setup-node@v3
+              uses: actions/setup-node@v4
               with:
                   node-version: ${{ matrix.node-version }}
             - run: npm ci
@@ -33,9 +33,9 @@ jobs:
                 node-version: [14.x]
 
         steps:
-            - uses: actions/checkout@v3
+            - uses: actions/checkout@v4
             - name: Use Node.js ${{ matrix.node-version }}
-              uses: actions/setup-node@v3
+              uses: actions/setup-node@v4
               with:
                   node-version: ${{ matrix.node-version }}
             - run: npm i -g npm@8
@@ -44,3 +44,17 @@ jobs:
             - run: npm run lint
             - run: npm run format:check
             - run: npm test
+
+    test_windows:
+        runs-on: windows-latest
+        steps:
+            - uses: actions/checkout@v4
+            - name: Use Node.js 18.x
+              uses: actions/setup-node@v4
+              with:
+                  node-version: 18.x
+            - run: npm ci
+            - run: npm run build
+            - run: npm run lint
+            - run: npm run format:check
+            - run: npm test

.prettierrc renamed to .prettierrc.json

@@ -1,8 +1,8 @@
 {
   "printWidth": 120,
-  "proseWrap": "always",
   "singleQuote": true,
   "trailingComma": "all",
   "arrowParens": "always",
-  "tabWidth": 4
+  "tabWidth": 4,
+  "endOfLine": "auto"
 }

examples/sdk/node/package.json

@@ -12,7 +12,7 @@
         "clean": "rimraf \"lib\"",
         "format": "prettier --write '**/*.ts'",
         "lint": "eslint . --ext .ts",
-        "start": "NODE_ENV=production node ./lib/index.js",
+        "start": "cross-env NODE_ENV=production node ./lib/index.js",
         "watch": "tsc -w"
     },
     "repository": {

package-lock.json

@@ -52,11 +52,12 @@
         "@types/semver": "^7.5.3",
         "@typescript-eslint/eslint-plugin": "^5.59.7",
         "@typescript-eslint/parser": "^5.59.7",
+        "cross-env": "^7.0.3",
         "eslint": "^8.41.0",
         "eslint-config-prettier": "^8.8.0",
         "eslint-plugin-import": "^2.27.5",
         "eslint-plugin-local-rules": "^1.3.2",
-        "prettier": "^2.8.8",
+        "prettier": "^3.3.2",
         "rimraf": "^5.0.1",
         "semver": "^7.5.4",
         "ts-node": "^10.9.1",

package.json

@@ -10,9 +10,9 @@
         "clean": "rimraf \"lib\"",
         "format": "prettier --write '**/*.ts'",
         "lint": "eslint . --ext .ts",
-        "prepublishOnly": "NODE_ENV=production npm run build",
+        "prepublishOnly": "cross-env NODE_ENV=production npm run build",
         "watch": "webpack -w",
-        "test": "NODE_ENV=test jest"
+        "test": "cross-env NODE_ENV=test jest"
     },
     "repository": {
         "type": "git",

packages/browser/package.json

@@ -9,9 +9,9 @@
         "clean": "rimraf common main renderer",
         "format": "prettier --write '**/*.ts'",
         "lint": "eslint src --ext .ts",
-        "prepublishOnly": "NODE_ENV=production npm run build",
+        "prepublishOnly": "cross-env NODE_ENV=production npm run build",
         "watch": "webpack -w",
-        "test": "NODE_ENV=test jest --passWithNoTests"
+        "test": "cross-env NODE_ENV=test jest --passWithNoTests"
     },
     "keywords": [
         "Error",

packages/electron/package.json

@@ -17,7 +17,10 @@ export interface WindowAttributeProviderOptions {
 }
 
 export class WindowAttributeProvider implements BacktraceAttributeProvider {
-    constructor(private readonly _window: BrowserWindow, private readonly _options?: WindowAttributeProviderOptions) {}
+    constructor(
+        private readonly _window: BrowserWindow,
+        private readonly _options?: WindowAttributeProviderOptions,
+    ) {}
 
     public readonly type = 'dynamic';
 

packages/electron/src/main/attributes/WindowAttributeProvider.ts

@@ -7,7 +7,11 @@ import { ipcHandshake } from '../../common/ipc/ipcHandshake';
 export class ReadableIpcStream extends Readable {
     private _isConnected = false;
 
-    constructor(private readonly _name: string, private readonly _ipc: IpcTransport, opts?: ReadableOptions) {
+    constructor(
+        private readonly _name: string,
+        private readonly _ipc: IpcTransport,
+        opts?: ReadableOptions,
+    ) {
         super(opts);
 
         const close = () => this.destroy();

packages/electron/src/main/ipc/ReadableIpcStream.ts

@@ -121,8 +121,11 @@ export class BacktraceMainElectronModule implements BacktraceModule {
 }
 
 function toStringDictionary(record: Record<string, unknown>): Record<string, string> {
-    return Object.keys(record).reduce((obj, key) => {
-        obj[key] = record[key]?.toString() ?? '';
-        return obj;
-    }, {} as Record<string, string>);
+    return Object.keys(record).reduce(
+        (obj, key) => {
+            obj[key] = record[key]?.toString() ?? '';
+            return obj;
+        },
+        {} as Record<string, string>,
+    );
 }