sdk-core: remove attachment record limits [INT-355]

Author: perf2711

packages/sdk-core/src/BacktraceCoreClient.ts

@@ -199,6 +199,7 @@ export abstract class BacktraceCoreClient<
                     },
                     setup.database?.reportRecordFactory ?? DefaultReportBacktraceDatabaseRecordFactory.default(),
                     this.sessionFiles,
+                    setup.database.recordLimits,
                 );
                 this._modules.set(BacktraceDatabase, database);
             }

packages/sdk-core/src/builder/CoreClientSetup.ts

@@ -8,6 +8,7 @@ import { BacktraceStackTraceConverter } from '../modules/converter/index.js';
 import { BacktraceDatabaseRecordSenders } from '../modules/database/BacktraceDatabaseRecordSender.js';
 import { BacktraceDatabaseRecordSerializers } from '../modules/database/BacktraceDatabaseRecordSerializer.js';
 import { ReportBacktraceDatabaseRecordFactory } from '../modules/database/ReportBacktraceDatabaseRecordFactory.js';
+import { BacktraceDatabaseRecordCountByType } from '../modules/database/index.js';
 import { BacktraceSessionProvider } from '../modules/metrics/BacktraceSessionProvider.js';
 import { MetricsQueue } from '../modules/metrics/MetricsQueue.js';
 import { SummedEvent } from '../modules/metrics/model/SummedEvent.js';
@@ -39,5 +40,6 @@ export interface CoreClientSetup<O extends BacktraceConfiguration = BacktraceCon
         readonly recordSerializers?: BacktraceDatabaseRecordSerializers;
         readonly recordSenders?: (submission: BacktraceReportSubmission) => BacktraceDatabaseRecordSenders;
         readonly reportRecordFactory?: ReportBacktraceDatabaseRecordFactory;
+        readonly recordLimits?: BacktraceDatabaseRecordCountByType;
     };
 }

packages/sdk-core/src/model/configuration/BacktraceDatabaseConfiguration.ts

@@ -17,13 +17,6 @@ export interface EnabledBacktraceDatabaseConfiguration {
      */
     maximumNumberOfRecords?: number;
 
-    /**
-     * The maximum number of attachments stored in the offline database. When the limit is reached,
-     * the oldest attachments are removed. If the value is equal to '0', then no limit is set.
-     * @default 10
-     */
-    maximumNumberOfAttachmentRecords?: number;
-
     /**
      * The amount of time (in ms) to wait between retries if the database is unable to send a report.
      * The default value is 60 000

packages/sdk-core/src/modules/database/BacktraceDatabase.ts

@@ -44,13 +44,14 @@ export class BacktraceDatabase extends Events<BacktraceDatabaseEvents> implement
         private readonly _recordSenders: BacktraceDatabaseRecordSenders,
         private readonly _reportRecordFactory: ReportBacktraceDatabaseRecordFactory,
         private readonly _sessionFiles?: SessionFiles,
+        recordLimits?: BacktraceDatabaseRecordCountByType,
     ) {
         super();
 
         this._databaseRecordContext = new BacktraceDatabaseContext(this._options?.maximumRetries);
         this._recordLimits = {
             report: this._options?.maximumNumberOfRecords ?? 8,
-            attachment: this._options?.maximumNumberOfAttachmentRecords ?? 10,
+            ...recordLimits,
         };
         this._retryInterval = this._options?.retryInterval ?? 60_000;
     }

packages/sdk-core/tests/database/databaseSetupTests.spec.ts

@@ -204,8 +204,6 @@ describe('Database setup tests', () => {
         const database = new BacktraceDatabase(
             {
                 autoSend: false,
-                maximumNumberOfRecords: 2,
-                maximumNumberOfAttachmentRecords: 3,
             },
             testStorageProvider,
             {
@@ -219,6 +217,11 @@ describe('Database setup tests', () => {
                 ),
             },
             DefaultReportBacktraceDatabaseRecordFactory.default(),
+            undefined,
+            {
+                report: 2,
+                attachment: 3,
+            },
         );
 
         const databaseStartResult = database.initialize();