Xbox native client improvements (#198)

* Add error.type attribute and set them only when we know the integration is available

* Check if the database path exists

Author: konraddysput

Runtime/Model/Attributes/RuntimeAttributeProvider.cs

@@ -13,6 +13,7 @@ public void GetAttributes(IDictionary<string, string> attributes)
                 return;
             }
 
+            attributes["backtrace.agent"] = "backtrace-unity";
             attributes["backtrace.version"] = BacktraceClient.VERSION;
             attributes["api.compatibility"] = GetApiCompatibility();
             attributes["scripting.backend"] = GetScriptingBackend();
@@ -24,8 +25,8 @@ public void GetAttributes(IDictionary<string, string> attributes)
             attributes["application.id"] = Application.identifier;
             attributes["application.package"] = Application.identifier;
             attributes["application.installer.name"] = Application.installerName;
-            attributes["application.editor"] = Application.isEditor.ToString(CultureInfo.InvariantCulture);            
-            attributes["application.mobile"] = Application.isMobilePlatform.ToString(CultureInfo.InvariantCulture);            
+            attributes["application.editor"] = Application.isEditor.ToString(CultureInfo.InvariantCulture);
+            attributes["application.mobile"] = Application.isMobilePlatform.ToString(CultureInfo.InvariantCulture);
             attributes["application.sandboxType"] = Application.sandboxType.ToString();
             attributes["application.system.language"] = Application.systemLanguage.ToString();
             attributes["application.unity.version"] = Application.unityVersion;

Runtime/Native/XBOX/NativeClient.cs

@@ -53,8 +53,8 @@ public NativeClient(BacktraceConfiguration configuration, BacktraceBreadcrumbs b
             {
                 return;
             }
+            HandleNativeCrashes(attachments);
             AddScopedAttributes(clientAttributes);
-            HandleNativeCrashes(clientAttributes, attachments);
         }
 
         public void GetAttributes(IDictionary<string, string> attributes)
@@ -86,18 +86,18 @@ public void SetAttribute(string key, string value)
 
         private void AddScopedAttributes(IDictionary<string, string> attributes)
         {
-            foreach (var attribute in attributes)
+            if (!CaptureNativeCrashes)
             {
-                if (string.IsNullOrEmpty(attribute.Key) || attribute.Value == null)
-                {
-                    continue;
-                }
+                return;
+            }
 
-                BacktraceAddAttribute(attribute.Key, attribute.Value);
+            foreach (var attribute in attributes)
+            {
+                SetAttribute(attribute.Key, attribute.Value);
             }
         }
 
-        private void HandleNativeCrashes(IDictionary<string, string> clientAttributes, IEnumerable<string> attachments)
+        private void HandleNativeCrashes(IEnumerable<string> attachments)
         {
             var integrationDisabled = !_configuration.CaptureNativeCrashes || !_configuration.Enabled;
             if (integrationDisabled)
@@ -108,19 +108,25 @@ private void HandleNativeCrashes(IDictionary<string, string> clientAttributes, I
             var minidumpUrl = new BacktraceCredentials(_configuration.GetValidServerUrl()).GetMinidumpSubmissionUrl().ToString();
             var dumpPath = _configuration.GetFullDatabasePath();
 
-            foreach (var attachment in attachments)
+            if (string.IsNullOrEmpty(dumpPath) || !Directory.Exists(dumpPath))
             {
-                var name = Path.GetFileName(attachment);
-                BacktraceAddFile(name, attachment);
+                Debug.LogWarning("Backtrace native integration status: database path doesn't exist");
+                return;
             }
-
             CaptureNativeCrashes = BacktraceNativeXboxInit(minidumpUrl, dumpPath);
 
             if (!CaptureNativeCrashes)
             {
                 Debug.LogWarning("Backtrace native integration status: Cannot initialize the Native Crash Reporting client");
                 return;
             }
+
+            BacktraceAddAttribute(ErrorTypeAttribute, CrashType);
+
+            foreach (var attachment in attachments)
+            {
+                BacktraceAddFile(Path.GetFileName(attachment), attachment);
+            }
         }
     }
 }